From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f71.google.com (mail-oi0-f71.google.com [209.85.218.71]) by kanga.kvack.org (Postfix) with ESMTP id B4BBB6B0006 for ; Mon, 5 Mar 2018 09:54:48 -0500 (EST) Received: by mail-oi0-f71.google.com with SMTP id a9so8393472oia.1 for ; Mon, 05 Mar 2018 06:54:48 -0800 (PST) Received: from foss.arm.com (foss.arm.com. [217.140.101.70]) by mx.google.com with ESMTP id s91si3874798otb.271.2018.03.05.06.54.47 for ; Mon, 05 Mar 2018 06:54:47 -0800 (PST) Date: Mon, 5 Mar 2018 14:54:36 +0000 From: Mark Rutland Subject: Re: [RFC PATCH 14/14] khwasan: default the instrumentation mode to inline Message-ID: <20180305145435.tfaldb334lp4obhi@lakrids.cambridge.arm.com> References: <1943a345f4fb7e8e8f19b4ece2457bccd772f0dc.1520017438.git.andreyknvl@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1943a345f4fb7e8e8f19b4ece2457bccd772f0dc.1520017438.git.andreyknvl@google.com> Sender: owner-linux-mm@kvack.org List-ID: To: Andrey Konovalov Cc: Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Jonathan Corbet , Catalin Marinas , Will Deacon , Theodore Ts'o , Jan Kara , Christopher Li , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Masahiro Yamada , Michal Marek , Ard Biesheuvel , Yury Norov , Nick Desaulniers , Marc Zyngier , Bob Picco , Suzuki K Poulose , Kristina Martsenko , Punit Agrawal , Dave Martin , James Morse , Julien Thierry , Michael Weiser , Steve Capper , Ingo Molnar , Thomas Gleixner , Sandipan Das , Paul Lawrence , David Woodhouse , Kees Cook , Geert Uytterhoeven , Josh Poimboeuf , Arnd Bergmann , kasan-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ext4@vger.kernel.org, linux-sparse@vger.kernel.org, linux-mm@kvack.org, linux-kbuild@vger.kernel.org, Kostya Serebryany , Evgeniy Stepanov , Lee Smith , Ramana Radhakrishnan , Jacob Bramley , Ruben Ayrapetyan , Kees Cook , Jann Horn , Mark Brand On Fri, Mar 02, 2018 at 08:44:33PM +0100, Andrey Konovalov wrote: > There are two reasons to use outline instrumentation: > 1. Outline instrumentation reduces the size of the kernel text, and should > be used where this size matters. > 2. Outline instrumentation is less invasive and can be used for debugging > for KASAN developers, when it's not clear whether some issue is caused > by KASAN or by something else. > > For the rest cases inline instrumentation is preferrable, since it's > faster. > > This patch changes the default instrumentation mode to inline. > --- > lib/Kconfig.kasan | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/Kconfig.kasan b/lib/Kconfig.kasan > index ab34e7d7d3a7..8ea6ae26b4a3 100644 > --- a/lib/Kconfig.kasan > +++ b/lib/Kconfig.kasan > @@ -70,7 +70,7 @@ config KASAN_EXTRA > choice > prompt "Instrumentation type" > depends on KASAN > - default KASAN_OUTLINE > + default KASAN_INLINE Some compilers don't support KASAN_INLINE, but do support KASAN_OUTLINE. IIRC that includes the latest clang release, but I could be wrong. If that's the case, changing the default here does not seem ideal. Thanks, Mark. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org