From: Matthew Wilcox <willy@infradead.org>
To: Jeff Layton <jlayton@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Matthew Wilcox <mawilcox@microsoft.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v7 02/61] radix tree: Use bottom four bits of gfp_t for flags
Date: Sat, 3 Mar 2018 09:09:44 -0800 [thread overview]
Message-ID: <20180303170944.GB29990@bombadil.infradead.org> (raw)
In-Reply-To: <1520081076.4280.18.camel@kernel.org>
On Sat, Mar 03, 2018 at 07:44:36AM -0500, Jeff Layton wrote:
> > - return root->gfp_mask & __GFP_BITS_MASK;
> > + return root->gfp_mask & ((__GFP_BITS_MASK >> 4) << 4);
>
> Maybe phrase this in terms of a constant like GFP_ZONEMASK here? Would
> this be more appropriate?
Yeah, that's a better idea. This is only interim; once all radix tree users
are converted to the xarray, we stop storing GFP flags here. So I hadn't
put much thought into it, but I'll change it.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2018-03-03 17:09 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-19 19:44 [PATCH v7 00/61] XArray version 7 -- for merging Matthew Wilcox
2018-02-19 19:44 ` [PATCH v7 01/61] radix tree test suite: Check reclaim bit Matthew Wilcox
2018-02-19 19:44 ` [PATCH v7 02/61] radix tree: Use bottom four bits of gfp_t for flags Matthew Wilcox
2018-03-03 12:44 ` Jeff Layton
2018-03-03 17:09 ` Matthew Wilcox [this message]
2018-02-19 19:44 ` [PATCH v7 03/61] arm64: Turn flush_dcache_mmap_lock into a no-op Matthew Wilcox
2018-02-19 19:44 ` [PATCH v7 04/61] unicore32: " Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 05/61] Export __set_page_dirty Matthew Wilcox
2018-03-03 13:56 ` Jeff Layton
2018-02-19 19:45 ` [PATCH v7 06/61] xfs: Rename xa_ elements to ail_ Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 07/61] fscache: Use appropriate radix tree accessors Matthew Wilcox
2018-03-03 13:57 ` Jeff Layton
2018-02-19 19:45 ` [PATCH v7 08/61] xarray: Add the xa_lock to the radix_tree_root Matthew Wilcox
2018-03-03 14:19 ` Jeff Layton
2018-03-03 14:55 ` Jeff Layton
2018-03-03 16:57 ` Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 09/61] page cache: Use xa_lock Matthew Wilcox
2018-03-03 14:27 ` Jeff Layton
2018-02-19 19:45 ` [PATCH v7 10/61] xarray: Replace exceptional entries Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 11/61] xarray: Change definition of sibling entries Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 12/61] xarray: Add definition of struct xarray Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 13/61] xarray: Define struct xa_node Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 14/61] xarray: Add documentation Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 15/61] xarray: Add xa_load Matthew Wilcox
2018-02-20 7:34 ` Philippe Ombredanne
2018-02-20 12:47 ` Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 16/61] xarray: Add xa_get_tag, xa_set_tag and xa_clear_tag Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 17/61] xarray: Add xa_store Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 18/61] xarray: Add xa_cmpxchg and xa_insert Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 19/61] xarray: Add xa_for_each Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 20/61] xarray: Add xa_extract Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 21/61] xarray: Add xa_destroy Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 22/61] xarray: Add xas_next and xas_prev Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 23/61] xarray: Add xas_create_range Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 24/61] xarray: Add MAINTAINERS entry Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 25/61] page cache: Convert hole search to XArray Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 26/61] page cache: Add page_cache_range_empty function Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 27/61] page cache: Add and replace pages using the XArray Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 28/61] page cache: Convert page deletion to XArray Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 29/61] page cache: Convert page cache lookups " Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 30/61] page cache: Convert delete_batch " Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 31/61] page cache: Remove stray radix comment Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 32/61] page cache: Convert filemap_range_has_page to XArray Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 33/61] mm: Convert page-writeback " Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 34/61] mm: Convert workingset " Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 35/61] mm: Convert truncate " Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 36/61] mm: Convert add_to_swap_cache " Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 37/61] mm: Convert delete_from_swap_cache " Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 38/61] mm: Convert __do_page_cache_readahead " Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 39/61] mm: Convert page migration " Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 40/61] mm: Convert huge_memory " Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 41/61] mm: Convert collapse_shmem " Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 42/61] mm: Convert khugepaged_scan_shmem " Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 43/61] pagevec: Use xa_tag_t Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 44/61] shmem: Convert replace to XArray Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 45/61] shmem: Convert shmem_confirm_swap " Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 46/61] shmem: Convert find_swap_entry " Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 47/61] shmem: Convert shmem_tag_pins " Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 48/61] shmem: Convert shmem_wait_for_pins " Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 49/61] shmem: Convert shmem_add_to_page_cache " Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 50/61] shmem: Convert shmem_alloc_hugepage " Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 51/61] shmem: Convert shmem_free_swap " Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 52/61] shmem: Convert shmem_partial_swap_usage " Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 53/61] shmem: Comment fixups Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 54/61] btrfs: Convert page cache to XArray Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 55/61] fs: Convert buffer " Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 56/61] fs: Convert writeback " Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 57/61] nilfs2: Convert " Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 58/61] f2fs: " Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 59/61] lustre: " Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 60/61] dax: " Matthew Wilcox
2018-02-19 19:45 ` [PATCH v7 61/61] page cache: Finish XArray conversion Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180303170944.GB29990@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mawilcox@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox