From: Minchan Kim <minchan@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm <linux-mm@kvack.org>,
lkml <linux-kernel@vger.kernel.org>,
Hugh Dickins <hughd@google.com>,
"Huang, Ying" <ying.huang@intel.com>
Subject: Re: [PATCH] mm:swap: do not check readahead flag with THP anon
Date: Wed, 28 Feb 2018 08:29:43 +0900 [thread overview]
Message-ID: <20180227232943.GC168047@rodete-desktop-imager.corp.google.com> (raw)
In-Reply-To: <20180227232611.169883-1-minchan@kernel.org>
On Wed, Feb 28, 2018 at 08:26:11AM +0900, Minchan Kim wrote:
> Huang reported PG_readahead flag marked PF_NO_COMPOUND so that
> we cannot use the flag for THP page. So, we need to check first
> whether page is THP or not before using TestClearPageReadahead
> in lookup_swap_cache.
>
> This patch fixes it.
>
> Furthermore, swap_[cluster|vma]_readahead cannot mark PG_readahead
> for newly allocated page because the allocated page is always a
> normal page, not THP at this moment. So let's clean it up, too.
>
> Cc: Hugh Dickins <hughd@google.com>
> Cc: "Huang, Ying" <ying.huang@intel.com>
> Signed-off-by: Minchan Kim <minchan@kernel.org>
Link:http://lkml.kernel.org/r/874lm83zho.fsf@yhuang-dev.intel.com
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2018-02-27 23:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 23:26 Minchan Kim
2018-02-27 23:29 ` Minchan Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180227232943.GC168047@rodete-desktop-imager.corp.google.com \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox