Re: [PATCH 0/2] mark some slabs as visible not mergeable

[David Miller <davem@redhat.com>]

From: Stephen Hemminger <stephen@networkplumber.org>
Date: Sat, 24 Feb 2018 11:04:52 -0800

> This fixes an old bug in iproute2's ss command because it was
> reading slabinfo to get statistics. There isn't a better API
> to do this, and one can argue that /proc is a UAPI that must
> not change.

Please elaborate what kind of statistics are needed.

> Therefore this patch set adds a flag to slab to give another
> reason to prevent merging, and then uses it in network code.
> 
> The patches are against davem's linux-net tree and should also
> goto stable as well.

Well, as has been pointed out this never worked with SLUB so
in some sense this was always broken.

And the "UAPI" of slabinfo is to show the state of the various
slab caches.  And that's it.

If the implementation does merging or whatever, the UAPI is expressing
that and it's perfectly legitimate and not breaking UAPI in my
opinion.

I think the better solution is to grab the information from somewhere
else, so let's move this conversation along with the answer to my
question about asking for more details about what is needed by
iproute2.

Thank you.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>