From: Alexey Dobriyan <adobriyan@gmail.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>,
kbuild-all@01.org
Subject: Re: [mmotm:master 110/152] fs/proc/inode.c:382:3-9: preceding lock on line 378 (fwd)
Date: Mon, 26 Feb 2018 01:21:04 +0300 [thread overview]
Message-ID: <20180225222104.GA26485@avx2> (raw)
In-Reply-To: <alpine.DEB.2.20.1802251747480.4584@hadrien>
On Sun, Feb 25, 2018 at 05:48:40PM +0100, Julia Lawall wrote:
> Please check whether an unlock is missing before line 382.
False positive.
> ---------- Forwarded message ----------
> Date: Mon, 26 Feb 2018 00:11:20 +0800
> From: kbuild test robot <fengguang.wu@intel.com>
> To: kbuild@01.org
> Cc: Julia Lawall <julia.lawall@lip6.fr>
> Subject: [mmotm:master 110/152] fs/proc/inode.c:382:3-9: preceding lock on line
> 378
>
> CC: kbuild-all@01.org
> TO: Alexey Dobriyan <adobriyan@gmail.com>
> CC: Johannes Weiner <hannes@cmpxchg.org>
> CC: Andrew Morton <akpm@linux-foundation.org>
> CC: Linux Memory Management List <linux-mm@kvack.org>
>
> tree: git://git.cmpxchg.org/linux-mmotm.git master
> head: 745388a34645dd2b69f5e7115ad47fea7a218726
> commit: 2e2d47fa3e1f9dff0e77de6edb123f024bf7841b [110/152] proc: do less stuff under ->pde_unload_lock
> :::::: branch date: 4 days ago
> :::::: commit date: 4 days ago
>
> >> fs/proc/inode.c:382:3-9: preceding lock on line 378
>
> git remote add mmotm git://git.cmpxchg.org/linux-mmotm.git
> git remote update mmotm
> git checkout 2e2d47fa3e1f9dff0e77de6edb123f024bf7841b
> vim +382 fs/proc/inode.c
>
> 786d7e16 Alexey Dobriyan 2007-07-15 373
> 786d7e16 Alexey Dobriyan 2007-07-15 374 static int proc_reg_release(struct inode *inode, struct file *file)
> 786d7e16 Alexey Dobriyan 2007-07-15 375 {
> 786d7e16 Alexey Dobriyan 2007-07-15 376 struct proc_dir_entry *pde = PDE(inode);
> 881adb85 Alexey Dobriyan 2008-07-25 377 struct pde_opener *pdeo;
> 786d7e16 Alexey Dobriyan 2007-07-15 @378 spin_lock(&pde->pde_unload_lock);
> ca469f35 Al Viro 2013-04-03 379 list_for_each_entry(pdeo, &pde->pde_openers, lh) {
> ca469f35 Al Viro 2013-04-03 380 if (pdeo->file == file) {
> ca469f35 Al Viro 2013-04-03 381 close_pdeo(pde, pdeo);
> 2e2d47fa Alexey Dobriyan 2018-02-21 @382 return 0;
> 786d7e16 Alexey Dobriyan 2007-07-15 383 }
> 881adb85 Alexey Dobriyan 2008-07-25 384 }
> 786d7e16 Alexey Dobriyan 2007-07-15 385 spin_unlock(&pde->pde_unload_lock);
> ca469f35 Al Viro 2013-04-03 386 return 0;
> 786d7e16 Alexey Dobriyan 2007-07-15 387 }
> 786d7e16 Alexey Dobriyan 2007-07-15 388
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2018-02-25 22:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-25 16:48 Julia Lawall
2018-02-25 22:21 ` Alexey Dobriyan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180225222104.GA26485@avx2 \
--to=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=julia.lawall@lip6.fr \
--cc=kbuild-all@01.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox