linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Daniel Colascione <dancol@google.com>
Cc: linux-mm@kvack.org
Subject: Re: [PATCH 1/2] Bug fixes for smaps_rollup
Date: Thu, 22 Feb 2018 14:31:02 -0800	[thread overview]
Message-ID: <20180222143102.e0ca18d0f64ee752947ad3fe@linux-foundation.org> (raw)
In-Reply-To: <20180222052659.106016-2-dancol@google.com>

On Wed, 21 Feb 2018 21:26:58 -0800 Daniel Colascione <dancol@google.com> wrote:

> Properly account and display pss_locked; behave properly when seq_file
> starts and stops multiple times on a single open file description,
> when when it issues multiple show calls, and when seq_file seeks to a
> non-zero position.

For each of these bugs can we please see a detailed description of the
misbehavior?  A good way of presenting that info is to show the
example commands, the resulting output and an explanation of why it was
wrong.  "behave properly" doesn't cut it ;)

There might be requests for one-fix-per-patch, too.  And it is the best
way, although I overlook that at times.

Please also attempt to cc the relevant developers.  `git blame' is a
good way of finding them.  Kirill, Oleg, adobriyan...

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2018-02-22 22:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-22  5:26 [PATCH 0/2] smaps bugfixes, new fields for locked memory Daniel Colascione
2018-02-22  5:26 ` [PATCH 1/2] Bug fixes for smaps_rollup Daniel Colascione
2018-02-22 22:31   ` Andrew Morton [this message]
2018-02-22  5:26 ` [PATCH 2/2] Add LockedRss/LockedPrivate to smaps and smaps_rollup Daniel Colascione

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180222143102.e0ca18d0f64ee752947ad3fe@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=dancol@google.com \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox