From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f72.google.com (mail-wm0-f72.google.com [74.125.82.72]) by kanga.kvack.org (Postfix) with ESMTP id 351DE6B02B0 for ; Thu, 22 Feb 2018 06:10:08 -0500 (EST) Received: by mail-wm0-f72.google.com with SMTP id j13so804140wmh.3 for ; Thu, 22 Feb 2018 03:10:08 -0800 (PST) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by mx.google.com with ESMTPS id u8si82882wme.216.2018.02.22.03.10.06 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Feb 2018 03:10:06 -0800 (PST) Date: Thu, 22 Feb 2018 12:10:03 +0100 From: Greg KH Subject: Re: [PATCH 00/31 v2] PTI support for x86_32 Message-ID: <20180222111003.GB22572@kroah.com> References: <20180209191112.55zyjf4njum75brd@suse.de> <20180210091543.ynypx4y3koz44g7y@angband.pl> <20180211105909.53bv5q363u7jgrsc@angband.pl> <6FB16384-7597-474E-91A1-1AF09201CEAC@gmail.com> <20180213085429.GB10278@kroah.com> <20180214085425.GA12779@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Arnd Bergmann Cc: Lorenzo Colitti , Linus Torvalds , Mark D Rustad , Adam Borowski , Joerg Roedel , Andy Lutomirski , Joerg Roedel , Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , X86 ML , LKML , Linux-MM , Dave Hansen , Josh Poimboeuf , Juergen Gross , Peter Zijlstra , Borislav Petkov , Jiri Kosina , Boris Ostrovsky , Brian Gerst , David Laight , Denys Vlasenko , Eduardo Valentin , Will Deacon , "Liguori, Anthony" , Daniel Gruss , Hugh Dickins , Kees Cook , Andrea Arcangeli , Waiman Long , Pavel Machek , Florian Westphal On Wed, Feb 21, 2018 at 05:59:34PM +0100, Arnd Bergmann wrote: > On Wed, Feb 21, 2018 at 11:26 AM, Lorenzo Colitti wrote: > > On Wed, Feb 14, 2018 at 5:54 PM, Greg KH wrote: > >> > > IPSEC doesn't work with a 64bit kernel and 32bit userspace right now. > >> > > > >> > > Back in 2015 someone started to work on that, and properly marked that > >> > > the kernel could not handle this with commit 74005991b78a ("xfrm: Do not > >> > > parse 32bits compiled xfrm netlink msg on 64bits host") > >> > > > >> > > This is starting to be hit by some Android systems that are moving > >> > > (yeah, slowly) to 4.4 :( > >> > > >> > Does anybody have test-programs/harnesses for this? > >> > >> Lorenzo (now on the To: line), is the one that I think is looking into > >> this, and should have some sort of test for it. Lorenzo? > > > > Sorry for the late reply here. The issue is that the xfrm uapi structs > > don't specify padding at the end, so they're a different size on > > 32-bit and 64-bit archs. This by itself would be fine, as the kernel > > could just ignore the (lack of) padding. But some of these structs > > contain others (e.g., xfrm_userspi_info contains xfrm_usersa_info), > > and in that case the whole layout after the contained struct is > > different. > > So this is x86 specific then and it already works correctly on all > other architectures (especially arm64 Android), right? Why is this an x86-specific issue? I think people have noticed this with ARM systems given that the original bug report I saw was for an ARM Android-based system that had a 64bit kernel and 32bit userspace. thanks, greg k-h -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org