linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mm/page_poison: Make early_page_poison_param __init
@ 2018-01-17  3:47 Dou Liyang
  2018-02-21 10:16 ` Michal Hocko
  0 siblings, 1 reply; 2+ messages in thread
From: Dou Liyang @ 2018-01-17  3:47 UTC (permalink / raw)
  To: linux-kernel
  Cc: Dou Liyang, Andrew Morton, Philippe Ombredanne, Kate Stewart,
	Michal Hocko, Greg Kroah-Hartman, linux-mm

The early_param() is only called during kernel initialization, So Linux
marks the function of it with __init macro to save memory.

But it forgot to mark the early_page_poison_param(). So, Make it __init
as well.

Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Philippe Ombredanne <pombredanne@nexb.com>
Cc: Kate Stewart <kstewart@linuxfoundation.org>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-mm@kvack.org
Signed-off-by: Dou Liyang <douly.fnst@cn.fujitsu.com>
---
 mm/page_poison.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/page_poison.c b/mm/page_poison.c
index e83fd44867de..aa2b3d34e8ea 100644
--- a/mm/page_poison.c
+++ b/mm/page_poison.c
@@ -9,7 +9,7 @@
 
 static bool want_page_poisoning __read_mostly;
 
-static int early_page_poison_param(char *buf)
+static int __init early_page_poison_param(char *buf)
 {
 	if (!buf)
 		return -EINVAL;
-- 
2.14.3



--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] mm/page_poison: Make early_page_poison_param __init
  2018-01-17  3:47 [PATCH] mm/page_poison: Make early_page_poison_param __init Dou Liyang
@ 2018-02-21 10:16 ` Michal Hocko
  0 siblings, 0 replies; 2+ messages in thread
From: Michal Hocko @ 2018-02-21 10:16 UTC (permalink / raw)
  To: Dou Liyang
  Cc: linux-kernel, Andrew Morton, Philippe Ombredanne, Kate Stewart,
	Greg Kroah-Hartman, linux-mm

On Wed 17-01-18 11:47:57, Dou Liyang wrote:
> The early_param() is only called during kernel initialization, So Linux
> marks the function of it with __init macro to save memory.
> 
> But it forgot to mark the early_page_poison_param(). So, Make it __init
> as well.
> 
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Philippe Ombredanne <pombredanne@nexb.com>
> Cc: Kate Stewart <kstewart@linuxfoundation.org>
> Cc: Michal Hocko <mhocko@suse.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: linux-mm@kvack.org
> Signed-off-by: Dou Liyang <douly.fnst@cn.fujitsu.com>

Acked-by: Michal Hocko <mhocko@suse.com>

> ---
>  mm/page_poison.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/page_poison.c b/mm/page_poison.c
> index e83fd44867de..aa2b3d34e8ea 100644
> --- a/mm/page_poison.c
> +++ b/mm/page_poison.c
> @@ -9,7 +9,7 @@
>  
>  static bool want_page_poisoning __read_mostly;
>  
> -static int early_page_poison_param(char *buf)
> +static int __init early_page_poison_param(char *buf)
>  {
>  	if (!buf)
>  		return -EINVAL;
> -- 
> 2.14.3
> 
> 
> 

-- 
Michal Hocko
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-02-21 10:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-17  3:47 [PATCH] mm/page_poison: Make early_page_poison_param __init Dou Liyang
2018-02-21 10:16 ` Michal Hocko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox