From: Michal Hocko <mhocko@kernel.org>
To: Dou Liyang <douly.fnst@cn.fujitsu.com>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Philippe Ombredanne <pombredanne@nexb.com>,
Kate Stewart <kstewart@linuxfoundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-mm@kvack.org
Subject: Re: [PATCH] mm/page_poison: Make early_page_poison_param __init
Date: Wed, 21 Feb 2018 11:16:26 +0100 [thread overview]
Message-ID: <20180221101626.GA14384@dhcp22.suse.cz> (raw)
In-Reply-To: <20180117034757.27024-1-douly.fnst@cn.fujitsu.com>
On Wed 17-01-18 11:47:57, Dou Liyang wrote:
> The early_param() is only called during kernel initialization, So Linux
> marks the function of it with __init macro to save memory.
>
> But it forgot to mark the early_page_poison_param(). So, Make it __init
> as well.
>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Philippe Ombredanne <pombredanne@nexb.com>
> Cc: Kate Stewart <kstewart@linuxfoundation.org>
> Cc: Michal Hocko <mhocko@suse.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: linux-mm@kvack.org
> Signed-off-by: Dou Liyang <douly.fnst@cn.fujitsu.com>
Acked-by: Michal Hocko <mhocko@suse.com>
> ---
> mm/page_poison.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/page_poison.c b/mm/page_poison.c
> index e83fd44867de..aa2b3d34e8ea 100644
> --- a/mm/page_poison.c
> +++ b/mm/page_poison.c
> @@ -9,7 +9,7 @@
>
> static bool want_page_poisoning __read_mostly;
>
> -static int early_page_poison_param(char *buf)
> +static int __init early_page_poison_param(char *buf)
> {
> if (!buf)
> return -EINVAL;
> --
> 2.14.3
>
>
>
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2018-02-21 10:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 3:47 Dou Liyang
2018-02-21 10:16 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180221101626.GA14384@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=douly.fnst@cn.fujitsu.com \
--cc=gregkh@linuxfoundation.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pombredanne@nexb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox