Re: [PATCH] mm: zsmalloc: Replace return type int with bool

[Minchan Kim <minchan@kernel.org>]

Hi Souptick,

On Tue, Feb 20, 2018 at 01:09:26PM +0530, Souptick Joarder wrote:
> On Tue, Feb 20, 2018 at 9:07 AM, kbuild test robot <lkp@intel.com> wrote:
> > Hi Souptick,
> >
> > Thank you for the patch! Perhaps something to improve:
> >
> > [auto build test WARNING on mmotm/master]
> > [also build test WARNING on v4.16-rc2 next-20180219]
> > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> >
> > url:    https://github.com/0day-ci/linux/commits/Souptick-Joarder/mm-zsmalloc-Replace-return-type-int-with-bool/20180220-070147
> > base:   git://git.cmpxchg.org/linux-mmotm.git master
> >
> >
> > coccinelle warnings: (new ones prefixed by >>)
> >
> >>> mm/zsmalloc.c:309:65-66: WARNING: return of 0/1 in function 'zs_register_migration' with return type bool
> >
> > Please review and possibly fold the followup patch.
> >
> 
> OK, I will send the v2.

First of all, thanks for the patch.

Yub, bool could be more appropriate. However, there are lots of other places
in kernel where use int instead of bool.
If we fix every such places with each patch, it would be very painful.
If you believe it's really worth, it would be better to find/fix every
such places in one patch. But I'm not sure it's worth.

Thanks.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>