Re: [PATCH v1] mm: Re-use DEFINE_SHOW_ATTRIBUTE() macro

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4382 bytes --]

Hi Andy,

I love your patch! Yet something to improve:

[auto build test ERROR on mmotm/master]
[also build test ERROR on v4.16-rc1 next-20180216]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Andy-Shevchenko/mm-Re-use-DEFINE_SHOW_ATTRIBUTE-macro/20180217-204603
base:   git://git.cmpxchg.org/linux-mmotm.git master
config: i386-randconfig-a1-201806 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   mm/backing-dev.c:104:1: warning: data definition has no type or storage class
    DEFINE_SHOW_ATTRIBUTE(bdi_debug_stats);
    ^
   mm/backing-dev.c:104:1: error: type defaults to 'int' in declaration of 'DEFINE_SHOW_ATTRIBUTE' [-Werror=implicit-int]
   mm/backing-dev.c:104:1: warning: parameter names (without types) in function declaration
   mm/backing-dev.c: In function 'bdi_debug_register':
>> mm/backing-dev.c:116:19: error: 'bdi_debug_stats_fops' undeclared (first use in this function)
                bdi, &bdi_debug_stats_fops);
                      ^
   mm/backing-dev.c:116:19: note: each undeclared identifier is reported only once for each function it appears in
   mm/backing-dev.c: At top level:
   mm/backing-dev.c:44:12: warning: 'bdi_debug_stats_show' defined but not used [-Wunused-function]
    static int bdi_debug_stats_show(struct seq_file *m, void *v)
               ^
   cc1: some warnings being treated as errors
--
   mm/zsmalloc.c:645:1: warning: data definition has no type or storage class
    DEFINE_SHOW_ATTRIBUTE(zs_stats_size);
    ^
   mm/zsmalloc.c:645:1: error: type defaults to 'int' in declaration of 'DEFINE_SHOW_ATTRIBUTE' [-Werror=implicit-int]
   mm/zsmalloc.c:645:1: warning: parameter names (without types) in function declaration
   mm/zsmalloc.c: In function 'zs_pool_stat_create':
>> mm/zsmalloc.c:664:30: error: 'zs_stat_size_ops' undeclared (first use in this function)
       pool->stat_dentry, pool, &zs_stat_size_ops);
                                 ^
   mm/zsmalloc.c:664:30: note: each undeclared identifier is reported only once for each function it appears in
   mm/zsmalloc.c: At top level:
   mm/zsmalloc.c:587:12: warning: 'zs_stats_size_show' defined but not used [-Wunused-function]
    static int zs_stats_size_show(struct seq_file *s, void *v)
               ^
   cc1: some warnings being treated as errors

vim +/bdi_debug_stats_fops +116 mm/backing-dev.c

76f1418b Miklos Szeredi  2008-04-30  103  
bdcdd49e Andy Shevchenko 2018-02-14 @104  DEFINE_SHOW_ATTRIBUTE(bdi_debug_stats);
76f1418b Miklos Szeredi  2008-04-30  105  
97f07697 weiping zhang   2017-10-31  106  static int bdi_debug_register(struct backing_dev_info *bdi, const char *name)
76f1418b Miklos Szeredi  2008-04-30  107  {
97f07697 weiping zhang   2017-10-31  108  	if (!bdi_debug_root)
97f07697 weiping zhang   2017-10-31  109  		return -ENOMEM;
97f07697 weiping zhang   2017-10-31  110  
76f1418b Miklos Szeredi  2008-04-30  111  	bdi->debug_dir = debugfs_create_dir(name, bdi_debug_root);
97f07697 weiping zhang   2017-10-31  112  	if (!bdi->debug_dir)
97f07697 weiping zhang   2017-10-31  113  		return -ENOMEM;
97f07697 weiping zhang   2017-10-31  114  
76f1418b Miklos Szeredi  2008-04-30  115  	bdi->debug_stats = debugfs_create_file("stats", 0444, bdi->debug_dir,
76f1418b Miklos Szeredi  2008-04-30 @116  					       bdi, &bdi_debug_stats_fops);
97f07697 weiping zhang   2017-10-31  117  	if (!bdi->debug_stats) {
97f07697 weiping zhang   2017-10-31  118  		debugfs_remove(bdi->debug_dir);
97f07697 weiping zhang   2017-10-31  119  		return -ENOMEM;
97f07697 weiping zhang   2017-10-31  120  	}
97f07697 weiping zhang   2017-10-31  121  
97f07697 weiping zhang   2017-10-31  122  	return 0;
76f1418b Miklos Szeredi  2008-04-30  123  }
76f1418b Miklos Szeredi  2008-04-30  124  

:::::: The code at line 116 was first introduced by commit
:::::: 76f1418b485da2707531178e517bbb5cf06b3c76 mm: bdi: move statistics to debugfs

:::::: TO: Miklos Szeredi <mszeredi@suse.cz>
:::::: CC: Linus Torvalds <torvalds@linux-foundation.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 24102 bytes --]