From: Andrew Morton <akpm@linux-foundation.org>
To: David Rientjes <rientjes@google.com>
Cc: Jonathan Corbet <corbet@lwn.net>,
Vlastimil Babka <vbabka@suse.cz>, Mel Gorman <mgorman@suse.de>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-doc@vger.kernel.org
Subject: Re: [patch 1/2] mm, page_alloc: extend kernelcore and movablecore for percent
Date: Tue, 13 Feb 2018 17:14:32 -0800 [thread overview]
Message-ID: <20180213171432.13c496c6603255bff66ce826@linux-foundation.org> (raw)
In-Reply-To: <alpine.DEB.2.10.1802131550210.130394@chino.kir.corp.google.com>
On Tue, 13 Feb 2018 15:55:11 -0800 (PST) David Rientjes <rientjes@google.com> wrote:
> >
> > Is this fine-grained enough? We've had percentage-based tunables in
> > the past, and 10 years later when systems are vastly larger, 1% is too
> > much.
> >
>
> They still have the (current) ability to define the exact amount of bytes
> down to page sized granularity, whereas 1% would yield 40GB on a 4TB
> system. I'm not sure that people will want any finer-grained control if
> defining the proportion of the system for kernelcore. They do have the
> ability with the existing interface, though, if they want to be that
> precise.
>
> (This is a cop out for not implementing some fractional percentage parser,
> although that would be possible as a more complete solution.)
And the interface which you've proposed can be seamlessly extended to
accept 0.07%, so not a problem.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2018-02-14 1:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 0:24 David Rientjes
2018-02-13 0:24 ` [patch 2/2] mm, page_alloc: move mirrored_kernelcore to __meminitdata David Rientjes
2018-02-13 23:46 ` [patch 1/2] mm, page_alloc: extend kernelcore and movablecore for percent Andrew Morton
2018-02-13 23:55 ` David Rientjes
2018-02-14 1:14 ` Andrew Morton [this message]
2018-02-14 0:37 ` Mike Kravetz
2018-02-14 0:53 ` David Rientjes
2018-02-14 1:00 ` [patch -mm] mm, page_alloc: extend kernelcore and movablecore for percent fix David Rientjes
2018-02-14 1:10 ` Mike Kravetz
2018-02-14 9:59 ` [patch 1/2] mm, page_alloc: extend kernelcore and movablecore for percent Michal Hocko
2018-02-14 10:28 ` David Rientjes
2018-02-15 14:45 ` Michal Hocko
2018-02-15 15:11 ` Matthew Wilcox
2018-02-15 15:49 ` Christopher Lameter
2018-02-15 20:14 ` Matthew Wilcox
2018-02-16 15:41 ` Christopher Lameter
2018-02-15 20:48 ` Matthew Wilcox
2018-02-16 0:45 ` David Rientjes
2018-02-16 15:44 ` Christopher Lameter
2018-02-16 16:01 ` Matthew Wilcox
2018-02-16 16:08 ` Christopher Lameter
2018-02-16 17:09 ` Matthew Wilcox
2018-02-15 20:47 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180213171432.13c496c6603255bff66ce826@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox