linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Pavel Tatashin <pasha.tatashin@oracle.com>
Cc: kbuild-all@01.org, steven.sistare@oracle.com,
	daniel.m.jordan@oracle.com, akpm@linux-foundation.org,
	mgorman@techsingularity.net, mhocko@suse.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
	vbabka@suse.cz, bharata@linux.vnet.ibm.com
Subject: Re: [PATCH v1] mm: optimize memory hotplug
Date: Fri, 2 Feb 2018 14:05:27 +0800	[thread overview]
Message-ID: <201802021339.Ld7kirF5%fengguang.wu@intel.com> (raw)
In-Reply-To: <20180131054243.28141-1-pasha.tatashin@oracle.com>

[-- Attachment #1: Type: text/plain, Size: 1998 bytes --]

Hi Pavel,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on mmotm/master]
[also build test ERROR on next-20180201]
[cannot apply to v4.15]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Pavel-Tatashin/mm-optimize-memory-hotplug/20180202-125437
base:   git://git.cmpxchg.org/linux-mmotm.git master
config: x86_64-randconfig-x017-201804 (attached as .config)
compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   mm/page_alloc.c: In function 'init_reserved_page':
>> mm/page_alloc.c:1215:44: error: 'zone' undeclared (first use in this function)
     __init_single_page(pfn_to_page(pfn), pfn, zone, nid);
                                               ^~~~
   mm/page_alloc.c:1215:44: note: each undeclared identifier is reported only once for each function it appears in

vim +/zone +1215 mm/page_alloc.c

  1196	
  1197	#ifdef CONFIG_DEFERRED_STRUCT_PAGE_INIT
  1198	static void __meminit init_reserved_page(unsigned long pfn)
  1199	{
  1200		pg_data_t *pgdat;
  1201		int nid, zid;
  1202	
  1203		if (!early_page_uninitialised(pfn))
  1204			return;
  1205	
  1206		nid = early_pfn_to_nid(pfn);
  1207		pgdat = NODE_DATA(nid);
  1208	
  1209		for (zid = 0; zid < MAX_NR_ZONES; zid++) {
  1210			struct zone *zone = &pgdat->node_zones[zid];
  1211	
  1212			if (pfn >= zone->zone_start_pfn && pfn < zone_end_pfn(zone))
  1213				break;
  1214		}
> 1215		__init_single_page(pfn_to_page(pfn), pfn, zone, nid);
  1216	}
  1217	#else
  1218	static inline void init_reserved_page(unsigned long pfn)
  1219	{
  1220	}
  1221	#endif /* CONFIG_DEFERRED_STRUCT_PAGE_INIT */
  1222	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34861 bytes --]

      parent reply	other threads:[~2018-02-02  6:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-31  5:42 Pavel Tatashin
2018-01-31  8:43 ` Michal Hocko
2018-01-31 18:38   ` Pavel Tatashin
2018-02-02  6:05 ` kbuild test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201802021339.Ld7kirF5%fengguang.wu@intel.com \
    --to=lkp@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=bharata@linux.vnet.ibm.com \
    --cc=daniel.m.jordan@oracle.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kbuild-all@01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=mhocko@suse.com \
    --cc=pasha.tatashin@oracle.com \
    --cc=steven.sistare@oracle.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox