From: Florian Westphal <fw@strlen.de>
To: Michal Hocko <mhocko@kernel.org>
Cc: Florian Westphal <fw@strlen.de>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
davem@davemloft.net, netfilter-devel@vger.kernel.org,
coreteam@netfilter.org, netdev@vger.kernel.org,
aarcange@redhat.com, yang.s@alibaba-inc.com,
syzkaller-bugs@googlegroups.com, linux-kernel@vger.kernel.org,
mingo@kernel.org, linux-mm@kvack.org, rientjes@google.com,
akpm@linux-foundation.org, guro@fb.com,
kirill.shutemov@linux.intel.com
Subject: Re: [netfilter-core] kernel panic: Out of memory and no killable processes... (2)
Date: Tue, 30 Jan 2018 09:11:27 +0100 [thread overview]
Message-ID: <20180130081127.GH5906@breakpoint.cc> (raw)
In-Reply-To: <20180130075226.GL21609@dhcp22.suse.cz>
Michal Hocko <mhocko@kernel.org> wrote:
> On Mon 29-01-18 23:35:22, Florian Westphal wrote:
> > Kirill A. Shutemov <kirill@shutemov.name> wrote:
> [...]
> > > I hate what I'm saying, but I guess we need some tunable here.
> > > Not sure what exactly.
> >
> > Would memcg help?
>
> That really depends. I would have to check whether vmalloc path obeys
> __GFP_ACCOUNT (I suspect it does except for page tables allocations but
> that shouldn't be a big deal). But then the other potential problem is
> the life time of the xt_table_info (or other potentially large) data
> structures. Are they bound to any process life time.
No.
> Because if they are
> not then the OOM killer will not help. The OOM panic earlier in this
> thread suggests it doesn't because the test case managed to eat all the
> available memory and killed all the eligible tasks which didn't help.
Yes, which is why we do not want any OOM killer invocation in first
place...
> So in some sense the memcg would help to stop the excessive allocation,
> but it wouldn't resolve it other than kill all tasks in the affected
> memcg/container. Whether this is sufficient or not, I dunno. It sounds
> quite suboptimal to me. But it is true this would be less tricky then
> adding a global knob...
Global knob doesn't really help at all, I can add multiple large
iptables rulesets (so we would have to account), and we have same issue
in virtually all of networking, so we need limits for interface count,
tunnel count, ipsec policies/SAs, nftables, tc, etc etc.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2018-01-30 8:14 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-28 17:58 syzbot
2018-01-29 0:20 ` Tetsuo Handa
2018-01-29 7:23 ` [netfilter-core] " Florian Westphal
2018-01-29 8:26 ` Kirill A. Shutemov
2018-01-29 16:57 ` Florian Westphal
2018-01-29 18:24 ` Jan Engelhardt
2018-01-29 18:25 ` Michal Hocko
2018-01-29 18:28 ` Kirill A. Shutemov
2018-01-29 22:35 ` Florian Westphal
2018-01-30 7:52 ` Michal Hocko
2018-01-30 8:11 ` Florian Westphal [this message]
2018-01-30 8:28 ` Kirill A. Shutemov
2018-01-30 9:02 ` Dmitry Vyukov
2018-01-30 9:57 ` Michal Hocko
2018-01-30 14:01 ` Michal Hocko
2018-01-30 14:01 ` Florian Westphal
2018-01-30 14:39 ` Michal Hocko
2018-02-02 11:41 ` Pablo Neira Ayuso
2018-01-30 19:27 ` Andrew Morton
2018-01-31 8:19 ` Michal Hocko
2018-02-07 17:44 ` Pablo Neira Ayuso
2018-02-07 19:06 ` Andrew Morton
2018-02-07 19:15 ` Pablo Neira Ayuso
2018-01-30 9:51 ` Michal Hocko
2018-03-23 10:40 ` Tetsuo Handa
2018-03-23 11:23 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180130081127.GH5906@breakpoint.cc \
--to=fw@strlen.de \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=guro@fb.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=rientjes@google.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=yang.s@alibaba-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox