From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f198.google.com (mail-pf0-f198.google.com [209.85.192.198]) by kanga.kvack.org (Postfix) with ESMTP id 797386B0009 for ; Sun, 28 Jan 2018 17:30:29 -0500 (EST) Received: by mail-pf0-f198.google.com with SMTP id m65so4516025pfm.14 for ; Sun, 28 Jan 2018 14:30:29 -0800 (PST) Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0125.outbound.protection.outlook.com. [104.47.42.125]) by mx.google.com with ESMTPS id y24si1811589pfa.194.2018.01.28.14.30.28 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 28 Jan 2018 14:30:28 -0800 (PST) From: Sasha Levin Subject: [PATCH AUTOSEL for 4.4 33/36] mm/early_ioremap: Fix boot hang with earlyprintk=efi,keep Date: Sun, 28 Jan 2018 22:28:48 +0000 Message-ID: <20180128222815.29479-33-alexander.levin@microsoft.com> References: <20180128222815.29479-1-alexander.levin@microsoft.com> In-Reply-To: <20180128222815.29479-1-alexander.levin@microsoft.com> Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: owner-linux-mm@kvack.org List-ID: To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" Cc: Dave Young , Linus Torvalds , Peter Zijlstra , "bp@suse.de" , "linux-efi@vger.kernel.org" , "linux-mm@kvack.org" , Ingo Molnar , Sasha Levin From: Dave Young [ Upstream commit 7f6f60a1ba52538c16f26930bfbcfe193d9d746a ] earlyprintk=3Defi,keep does not work any more with a warning in mm/early_ioremap.c: WARN_ON(system_state !=3D SYSTEM_BOOTING): Boot just hangs because of the earlyprintk within the earlyprintk implementation code itself. This is caused by a new introduced middle state in: 69a78ff226fe ("init: Introduce SYSTEM_SCHEDULING state") early_ioremap() is fine in both SYSTEM_BOOTING and SYSTEM_SCHEDULING states, original condition should be updated accordingly. Signed-off-by: Dave Young Acked-by: Thomas Gleixner Cc: Linus Torvalds Cc: Peter Zijlstra Cc: bp@suse.de Cc: linux-efi@vger.kernel.org Cc: linux-mm@kvack.org Link: http://lkml.kernel.org/r/20171209041610.GA3249@dhcp-128-65.nay.redhat= .com Signed-off-by: Ingo Molnar Signed-off-by: Sasha Levin --- mm/early_ioremap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/early_ioremap.c b/mm/early_ioremap.c index 6d5717bd7197..57540de2b44c 100644 --- a/mm/early_ioremap.c +++ b/mm/early_ioremap.c @@ -103,7 +103,7 @@ __early_ioremap(resource_size_t phys_addr, unsigned lon= g size, pgprot_t prot) enum fixed_addresses idx; int i, slot; =20 - WARN_ON(system_state !=3D SYSTEM_BOOTING); + WARN_ON(system_state >=3D SYSTEM_RUNNING); =20 slot =3D -1; for (i =3D 0; i < FIX_BTMAPS_SLOTS; i++) { --=20 2.11.0 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org