From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Ingo Molnar <mingo@redhat.com>,
x86@kernel.org, Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Borislav Petkov <bp@suse.de>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] x86/mm/encrypt: Move sme_populate_pgd*() into separate translation unit
Date: Wed, 24 Jan 2018 18:52:27 +0300 [thread overview]
Message-ID: <20180124155227.wg7itpohsvd2i7wt@black.fi.intel.com> (raw)
In-Reply-To: <1dee5138-fe8e-70ec-61d1-86f802e68e7c@amd.com>
On Wed, Jan 24, 2018 at 02:59:58PM +0000, Tom Lendacky wrote:
> > static void __init sme_clear_pgd(struct sme_populate_pgd_data *ppd)
>
> If you're going to move some of the functions, did you look at moving the
> sme_enable(), sme_encrypt_kernel(), etc., too? I believe everything below
> the sme_populate_pgd_data structure is used during early identity-mapped
> boot time. If you move everything, then mm_internal.h doesn't need to be
> updated and all of the identity-mapped early boot code ends up in one
> file.
>
> You'd have to move the command line declarations and make sev_enabled
> not a static, but it should be doable.
I moved minimum of the code to get the trick work, but I'll look into
moving move there.
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2018-01-24 15:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 17:19 [PATCHv2 0/3] x86/mm/encrypt: Cleanup and switching between paging modes Kirill A. Shutemov
2018-01-23 17:19 ` [PATCH 1/3] x86/mm/encrypt: Move sme_populate_pgd*() into separate translation unit Kirill A. Shutemov
2018-01-24 10:36 ` Kirill A. Shutemov
2018-01-24 14:59 ` Tom Lendacky
2018-01-24 15:52 ` Kirill A. Shutemov [this message]
2018-01-23 17:19 ` [PATCH 2/3] x86/mm/encrypt: Rewrite sme_populate_pgd() and sme_populate_pgd_large() Kirill A. Shutemov
2018-01-23 17:19 ` [PATCH 3/3] x86/mm/encrypt: Rewrite sme_pgtable_calc() Kirill A. Shutemov
-- strict thread matches above, loose matches on Subject: below --
2017-12-12 11:45 [PATCH 0/3] x86/mm/encrypt: Simplify pgtable helpers Kirill A. Shutemov
2017-12-12 11:45 ` [PATCH 1/3] x86/mm/encrypt: Move sme_populate_pgd*() into separate translation unit Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180124155227.wg7itpohsvd2i7wt@black.fi.intel.com \
--to=kirill.shutemov@linux.intel.com \
--cc=bp@suse.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox