From: Ingo Molnar <mingo@kernel.org>
To: Tony Luck <tony.luck@intel.com>
Cc: Borislav Petkov <bp@suse.de>,
Denys Vlasenko <dvlasenk@redhat.com>,
linux-mm@kvack.org, Peter Zijlstra <peterz@infradead.org>,
Brian Gerst <brgerst@gmail.com>,
"Hansen, Dave" <dave.hansen@intel.com>,
Andy Lutomirski <luto@kernel.org>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
"Robert (Persistent Memory)" <elliott@hpe.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCHv2-resend] x86/mm, mm/hwpoison: Don't unconditionally unmap kernel 1:1 pages.
Date: Tue, 16 Jan 2018 04:09:32 +0100 [thread overview]
Message-ID: <20180116030932.itshfy2i4326bvoo@gmail.com> (raw)
In-Reply-To: <20180110201947.32727-1-tony.luck@intel.com>
* Tony Luck <tony.luck@intel.com> wrote:
> v1->v2 0-day reported a build warning on 32-bit. Don't do 32-bit (see comment
> at end of commit message). This fixed the build error, but then discussion on
> the list went quiet. Repost to wake things up.
It seems dubious to me to introduce a difference in behavior on 32-bit:
> +static void mce_unmap_kpfn(unsigned long pfn)
> +{
> +#ifdef CONFIG_X86_64
> + unsigned long decoy_addr;
> + if (set_memory_np(decoy_addr, 1))
> + pr_warn("Could not invalidate pfn=0x%lx from 1:1 map\n", pfn);
> +#endif
... to fix a build warning?
32-bit kernels might be under-tested, but if it's supposed to work I don't think
we should bifurcate the behavior and uglify the code here.
Thanks,
Ingo
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2018-01-16 3:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tip-f1a041552c403949ab3c0902c1030c3a3d186ec1@git.kernel.org>
2017-11-29 19:24 ` [PATCHv2] " Tony Luck
2018-01-10 20:19 ` [PATCHv2-resend] " Tony Luck
2018-01-16 3:09 ` Ingo Molnar [this message]
2018-01-16 19:43 ` Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180116030932.itshfy2i4326bvoo@gmail.com \
--to=mingo@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bp@suse.de \
--cc=brgerst@gmail.com \
--cc=dave.hansen@intel.com \
--cc=dvlasenk@redhat.com \
--cc=elliott@hpe.com \
--cc=jpoimboe@redhat.com \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox