From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f198.google.com (mail-wr0-f198.google.com [209.85.128.198]) by kanga.kvack.org (Postfix) with ESMTP id 240876B0033 for ; Fri, 12 Jan 2018 09:10:46 -0500 (EST) Received: by mail-wr0-f198.google.com with SMTP id w103so3531600wrb.2 for ; Fri, 12 Jan 2018 06:10:46 -0800 (PST) Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id c56sor4207649wrc.54.2018.01.12.06.10.44 for (Google Transport Security); Fri, 12 Jan 2018 06:10:44 -0800 (PST) Date: Fri, 12 Jan 2018 15:10:37 +0100 From: Ingo Molnar Subject: Re: [PATCHv6 0/4] x86: 5-level related changes into decompression code Message-ID: <20180112141037.ktd2ryzx3tfwhsfx@gmail.com> References: <20171212135739.52714-1-kirill.shutemov@linux.intel.com> <20171218101045.arwbzmbxbhqgreeu@node.shutemov.name> <20180108161805.jrpmkcrwlr2rs4sy@gmail.com> <20180112083757.okwsvdhqaodt2d3u@node.shutemov.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180112083757.okwsvdhqaodt2d3u@node.shutemov.name> Sender: owner-linux-mm@kvack.org List-ID: To: "Kirill A. Shutemov" Cc: Ingo Molnar , "Kirill A. Shutemov" , x86@kernel.org, Thomas Gleixner , "H. Peter Anvin" , Linus Torvalds , Andy Lutomirski , Cyrill Gorcunov , Borislav Petkov , Andi Kleen , linux-mm@kvack.org, linux-kernel@vger.kernel.org * Kirill A. Shutemov wrote: > On Mon, Jan 08, 2018 at 05:18:05PM +0100, Ingo Molnar wrote: > > > > * Kirill A. Shutemov wrote: > > > > > On Tue, Dec 12, 2017 at 04:57:35PM +0300, Kirill A. Shutemov wrote: > > > > Here's few changes to x86 decompression code. > > > > > > > > The first patch is pure cosmetic change: it gives file with KASLR helpers > > > > a proper name. > > > > > > > > The last three patches bring support of booting into 5-level paging mode if > > > > a bootloader put the kernel above 4G. > > > > > > > > Patch 2/4 Renames l5_paging_required() into paging_prepare() and change > > > > interface of the function. > > > > Patch 3/4 Handles allocation of space for trampoline and gets it prepared. > > > > Patch 4/4 Gets trampoline used. > > > > > > > > Kirill A. Shutemov (4): > > > > x86/boot/compressed/64: Rename pagetable.c to kaslr_64.c > > > > x86/boot/compressed/64: Introduce paging_prepare() > > > > x86/boot/compressed/64: Prepare trampoline memory > > > > x86/boot/compressed/64: Handle 5-level paging boot if kernel is above > > > > 4G > > > > > > Ingo, does it look fine now? > > > > Yes, it looks structurally much better now - but we first need to address all > > existing regressions before we can move forward. > > There's a fix for kdump issue that maintainers are okay about. Do you mean your proposed fix in: Message-ID: <20180109001303.dy73bpixsaegn4ol@node.shutemov.name> ? I was expecting a final submission of that fix in a new thread (or at least with a new subject line), with all Acked-by and Tested-by's collected and Reported-by added in. > Is there any other regression do you have in mind? No, that's the main one I was worried about. Thanks, Ingo -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org