From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f70.google.com (mail-pl0-f70.google.com [209.85.160.70]) by kanga.kvack.org (Postfix) with ESMTP id A20016B0636 for ; Sat, 6 Jan 2018 11:19:20 -0500 (EST) Received: by mail-pl0-f70.google.com with SMTP id q12so5136129plk.16 for ; Sat, 06 Jan 2018 08:19:20 -0800 (PST) Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id h12sor2552242pls.124.2018.01.06.08.19.18 for (Google Transport Security); Sat, 06 Jan 2018 08:19:19 -0800 (PST) Date: Sat, 6 Jan 2018 09:19:11 -0700 From: Jens Axboe Subject: Re: [PATCH V4 15/45] block: rename bio_for_each_segment* with bio_for_each_page* Message-ID: <20180106161909.GA6343@kernel.dk> References: <20171218122247.3488-1-ming.lei@redhat.com> <20171218122247.3488-16-ming.lei@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171218122247.3488-16-ming.lei@redhat.com> Sender: owner-linux-mm@kvack.org List-ID: To: Ming Lei Cc: Christoph Hellwig , Alexander Viro , Kent Overstreet , Huang Ying , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Theodore Ts'o , "Darrick J . Wong" , Coly Li , Filipe Manana On Mon, Dec 18 2017, Ming Lei wrote: > It is a tree-wide mechanical replacement since both bio_for_each_segment() > and bio_for_each_segment_all() never returns real segment at all, and > both just return one page per bvec and deceive us for long time, so fix > their names. > > This is a pre-patch for supporting multipage bvec. Once multipage bvec > is in, each bvec will store a real multipage segment, so people won't be > confused with these wrong names. No, we're not doing this, it's a pretty pointless tree wide replacement with a fairly weak justification. -- Jens Axboe -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org