From: Michal Hocko <mhocko@suse.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: kbuild test robot <fengguang.wu@intel.com>,
kbuild-all@01.org, Johannes Weiner <hannes@cmpxchg.org>,
Mike Kravetz <mike.kravetz@oracle.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Linux Memory Management List <linux-mm@kvack.org>,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [mmotm:master 152/256] mm/migrate.c:1934:53: sparse: incorrect type in argument 2 (different argument counts)
Date: Fri, 5 Jan 2018 21:59:03 +0100 [thread overview]
Message-ID: <20180105205903.GV2801@dhcp22.suse.cz> (raw)
In-Reply-To: <20180105124239.8d9c4e5631b8488807349f89@linux-foundation.org>
On Fri 05-01-18 12:42:39, Andrew Morton wrote:
> On Fri, 5 Jan 2018 15:29:12 +0800 kbuild test robot <fengguang.wu@intel.com> wrote:
>
> > Hi Michal,
> >
> > First bad commit (maybe != root cause):
> >
> > tree: git://git.cmpxchg.org/linux-mmotm.git master
> > head: 1ceb98996d2504dd4e0bcb5f4cb9009a18cd8aaa
> > commit: 37870392dd6966328ed2fe49a247ab37d6fa7344 [152/256] mm, hugetlb: unify core page allocation accounting and initialization
> > reproduce:
> > # apt-get install sparse
> > git checkout 37870392dd6966328ed2fe49a247ab37d6fa7344
> > make ARCH=x86_64 allmodconfig
> > make C=1 CF=-D__CHECK_ENDIAN__
> >
> >
>
> --- a/mm/migrate.c~mm-migrate-remove-reason-argument-from-new_page_t-fix-fix
> +++ a/mm/migrate.c
> @@ -1784,8 +1784,7 @@ static bool migrate_balanced_pgdat(struc
> }
>
> static struct page *alloc_misplaced_dst_page(struct page *page,
> - unsigned long data,
> - int **result)
> + unsigned long data)
> {
> int nid = (int) data;
> struct page *newpage;
> _
>
> That's against mm-migrate-remove-reason-argument-from-new_page_t.patch.
Yeah http://lkml.kernel.org/r/20180105090753.GI2801@dhcp22.suse.cz
and another that sneaked in http://lkml.kernel.org/r/20180105085259.GH2801@dhcp22.suse.cz
I really do not know how this passed my standard build test batery.
Something must have been clearly broken there.
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2018-01-05 20:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-05 7:29 kbuild test robot
2018-01-05 20:42 ` Andrew Morton
2018-01-05 20:59 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180105205903.GV2801@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=hannes@cmpxchg.org \
--cc=kbuild-all@01.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox