From: Joey Pabalinas <joeypabalinas@gmail.com>
To: linux-mm@kvack.org
Cc: sjenning@redhat.com, ddstreet@ieee.org,
linux-kernel@vger.kernel.org,
Joey Pabalinas <joeypabalinas@gmail.com>
Subject: [PATCH 2/2] mm/zswap: move `zswap_has_pool` to front of `if ()`
Date: Tue, 2 Jan 2018 00:03:20 -1000 [thread overview]
Message-ID: <20180102100320.24801-3-joeypabalinas@gmail.com> (raw)
In-Reply-To: <20180102100320.24801-1-joeypabalinas@gmail.com>
`zwap_has_pool` is a simple boolean, so it should be tested first
to avoid unnecessarily calling `strcmp()`. Test `zswap_has_pool`
first to take advantage of the short-circuiting behavior of && in
`__zswap_param_set()`.
Signed-off-by: Joey Pabalinas <joeypabalinas@gmail.com>
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/zswap.c b/mm/zswap.c
index a4f2dfaf9131694265..dbf35139471f692798 100644
--- a/mm/zswap.c
+++ b/mm/zswap.c
@@ -672,7 +672,7 @@ static int __zswap_param_set(const char *val, const struct kernel_param *kp,
}
/* no change required */
- if (!strcmp(s, *(char **)kp->arg) && zswap_has_pool)
+ if (zswap_has_pool && !strcmp(s, *(char **)kp->arg))
return 0;
/* if this is load-time (pre-init) param setting,
--
2.15.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2018-01-02 10:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-02 10:03 [PATCH 0/2] mm/zswap: add minor const/conditional optimizations Joey Pabalinas
2018-01-02 10:03 ` [PATCH 1/2] mm/zswap: make type and compressor const Joey Pabalinas
2018-01-08 19:22 ` Dan Streetman
2018-01-02 10:03 ` Joey Pabalinas [this message]
2018-01-08 19:34 ` [PATCH 2/2] mm/zswap: move `zswap_has_pool` to front of `if ()` Dan Streetman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180102100320.24801-3-joeypabalinas@gmail.com \
--to=joeypabalinas@gmail.com \
--cc=ddstreet@ieee.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sjenning@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox