From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Jesper Dangaard Brouer <brouer@redhat.com>
Cc: linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org,
tglx@linutronix.de, Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Vladimir Davydov <vdavydov@virtuozzo.com>,
linux-mm@kvack.org, Rao Shoaib <rao.shoaib@oracle.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: Re: [PATCH RT] mm/slub: close possible memory-leak in kmem_cache_alloc_bulk()
Date: Wed, 13 Dec 2017 15:50:44 +0100 [thread overview]
Message-ID: <20171213145044.falrw5jsskq2ocha@linutronix.de> (raw)
In-Reply-To: <20171213154654.2971ef2a@redhat.com>
On 2017-12-13 15:46:54 [+0100], Jesper Dangaard Brouer wrote:
> > Jesper: There are no users of kmem_cache_alloc_bulk() and kfree_bulk().
> > Only kmem_cache_free_bulk() is used since it was introduced. Do you
> > think that it would make sense to remove those?
>
> I would like to keep them.
>
> Rao Shoaib (Cc'ed) is/was working on a patchset for RCU-bulk-free that
> used the kfree_bulk() API.
>
> I plan to use kmem_cache_alloc_bulk() in the bpf-map "cpumap", for bulk
> allocating SKBs during dequeue of XDP frames. (My original bulk alloc
> SKBs use-case during NAPI/softirq was never merged).
I see. So it may gain users in future you say.
> I've not seen free_delayed() before... and my cscope cannot find it...
It is PREEMPT RT only, mainline is not affected (that is why there is a
RT next to the PATCH in subject).
Sebastian
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2017-12-13 14:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-13 14:05 Sebastian Andrzej Siewior
2017-12-13 14:46 ` Jesper Dangaard Brouer
2017-12-13 14:50 ` Sebastian Andrzej Siewior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171213145044.falrw5jsskq2ocha@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=brouer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rao.shoaib@oracle.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=vdavydov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox