From: "Du, Changbin" <changbin.du@intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: changbin.du@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mm, thp: introduce generic transparent huge page allocation interfaces
Date: Fri, 8 Dec 2017 10:27:05 +0800 [thread overview]
Message-ID: <20171208022704.7kcoky7si2suqelt@intel.com> (raw)
In-Reply-To: <20171207154519.df3f8218f8dbe05f95a2bc42@linux-foundation.org>
Hi Andrew,
On Thu, Dec 07, 2017 at 03:45:19PM -0800, Andrew Morton wrote:
> On Thu, 7 Dec 2017 18:54:19 +0800 changbin.du@intel.com wrote:
>
> > From: Changbin Du <changbin.du@intel.com>
[snip]
> -static inline void prep_transhuge_page(struct page *page) {}
> > +#define alloc_transhuge_page_vma(gfp_mask, vma, addr) NULL
> > +#define alloc_transhuge_page_nodemask(gfp_mask, preferred_nid, nmask) NULL
> > +#define alloc_transhuge_page_node(nid, gfp_maskg) NULL
> > +#define alloc_transhuge_page(gfp_mask) NULL
>
> Ugly. And such things can cause unused-variable warnings in calling
> code. Whereas
>
> static inline struct page *alloc_transhuge_page_vma(gfp_t gfp_mask,
> struct vm_area_struct *vma, unsigned long addr)
> {
> return NULL;
> }
>
> will avoid such warnings.
>
Thanks for pointing out, I will update it.
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
Thanks,
Changbin Du
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2017-12-08 2:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 10:54 changbin.du
2017-12-07 23:45 ` Andrew Morton
2017-12-08 2:27 ` Du, Changbin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171208022704.7kcoky7si2suqelt@intel.com \
--to=changbin.du@intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox