From: Michal Hocko <mhocko@kernel.org>
To: Suren Baghdasaryan <surenb@google.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
hillf.zj@alibaba-inc.com, minchan@kernel.org,
mgorman@techsingularity.net, ying.huang@intel.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Tim Murray <timmurray@google.com>, Todd Kjos <tkjos@google.com>
Subject: Re: [PATCH] mm: terminate shrink_slab loop if signal is pending
Date: Thu, 7 Dec 2017 17:25:25 +0100 [thread overview]
Message-ID: <20171207162525.GL20234@dhcp22.suse.cz> (raw)
In-Reply-To: <CAJuCfpEqReQBLXWX9mG9fm9wgMr_4WMHfxHe8GgG-1+sYuPkXA@mail.gmail.com>
On Thu 07-12-17 07:46:07, Suren Baghdasaryan wrote:
> I'm, terribly sorry. My original code was checking for additional
> condition which I realized is not useful here because it would mean
> the signal was already processed. Should have missed the error while
> removing it. Will address Michal's comments and fix the problem.
yes, rebasing at last moment tend to screw things... No worries, I would
be more worried about the general approach here and its documentataion.
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2017-12-07 16:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 19:20 Suren Baghdasaryan
2017-12-06 23:26 ` Andrew Morton
2017-12-07 1:27 ` Suren Baghdasaryan
2017-12-07 8:34 ` Michal Hocko
2017-12-07 14:34 ` Tetsuo Handa
2017-12-08 0:44 ` Suren Baghdasaryan
2017-12-08 4:37 ` Suren Baghdasaryan
2017-12-08 4:40 ` Suren Baghdasaryan
2017-12-07 9:52 ` Sergey Senozhatsky
2017-12-07 9:58 ` Michal Hocko
2017-12-07 15:46 ` Suren Baghdasaryan
2017-12-07 16:25 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171207162525.GL20234@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=hillf.zj@alibaba-inc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=minchan@kernel.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=surenb@google.com \
--cc=timmurray@google.com \
--cc=tkjos@google.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox