[PATCH] mm/huge_memory: fix comment in __split_huge_pmd_locked

[PATCH] mm/huge_memory: fix comment in __split_huge_pmd_locked

[Yisheng Xie]

pmd_trans_splitting has been remove after THP refcounting redesign,
therefore related comment should be updated.

Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
---
 mm/huge_memory.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index 86fe697..f2467a0 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -2215,10 +2215,9 @@ static void __split_huge_pmd_locked(struct vm_area_struct *vma, pmd_t *pmd,
 	 * for the same virtual address to be loaded simultaneously. So instead
 	 * of doing "pmd_populate(); flush_pmd_tlb_range();" we first mark the
 	 * current pmd notpresent (atomically because here the pmd_trans_huge
-	 * and pmd_trans_splitting must remain set at all times on the pmd
-	 * until the split is complete for this pmd), then we flush the SMP TLB
-	 * and finally we write the non-huge version of the pmd entry with
-	 * pmd_populate.
+	 * must remain set at all times on the pmd until the split is complete
+	 * for this pmd), then we flush the SMP TLB and finally we write the
+	 * non-huge version of the pmd entry with pmd_populate.
 	 */
 	pmdp_invalidate(vma, haddr, pmd);
 	pmd_populate(mm, pmd, pgtable);
-- 
1.7.12.4

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] mm/huge_memory: fix comment in __split_huge_pmd_locked

[Kirill A. Shutemov]

On Thu, Dec 07, 2017 at 01:49:05PM +0800, Yisheng Xie wrote:
> pmd_trans_splitting has been remove after THP refcounting redesign,
> therefore related comment should be updated.
> 
> Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>

Looks good to me.

Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>

-- 
 Kirill A. Shutemov

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>