linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [linux-next:master 2148/2944] lib/find_bit_benchmark.c:115:7: error: implicit declaration of function 'find_next_and_bit'; did you mean 'find_next_bit'?
@ 2017-12-05 12:31 kbuild test robot
  2017-12-06  0:09 ` Andrew Morton
  0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2017-12-05 12:31 UTC (permalink / raw)
  To: Clement Courbet; +Cc: kbuild-all, Andrew Morton, Linux Memory Management List

[-- Attachment #1: Type: text/plain, Size: 1778 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   7ceb97a071e80f1b5e4cd5a36de135612a836388
commit: e49c614e6b37254b1e7bf55c631ce3cb5e3b6433 [2148/2944] lib: optimize cpumask_next_and()
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout e49c614e6b37254b1e7bf55c631ce3cb5e3b6433
        # save the attached .config to linux build tree
        make.cross ARCH=m68k 

All errors (new ones prefixed by >>):

   lib/find_bit_benchmark.c: In function 'test_find_next_and_bit':
>> lib/find_bit_benchmark.c:115:7: error: implicit declaration of function 'find_next_and_bit'; did you mean 'find_next_bit'? [-Werror=implicit-function-declaration]
      i = find_next_and_bit(bitmap, bitmap2, BITMAP_LEN, i+1);
          ^~~~~~~~~~~~~~~~~
          find_next_bit
   cc1: some warnings being treated as errors

vim +115 lib/find_bit_benchmark.c

   106	
   107	static int __init test_find_next_and_bit(const void *bitmap,
   108			const void *bitmap2, unsigned long len)
   109	{
   110		unsigned long i, cnt;
   111		cycles_t cycles;
   112	
   113		cycles = get_cycles();
   114		for (cnt = i = 0; i < BITMAP_LEN; cnt++)
 > 115			i = find_next_and_bit(bitmap, bitmap2, BITMAP_LEN, i+1);
   116		cycles = get_cycles() - cycles;
   117		pr_err("find_next_and_bit: %ld cycles, %ld iterations\n", (long)cycles,
   118			cnt);
   119	
   120		return 0;
   121	}
   122	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 45145 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [linux-next:master 2148/2944] lib/find_bit_benchmark.c:115:7: error: implicit declaration of function 'find_next_and_bit'; did you mean 'find_next_bit'?
  2017-12-05 12:31 [linux-next:master 2148/2944] lib/find_bit_benchmark.c:115:7: error: implicit declaration of function 'find_next_and_bit'; did you mean 'find_next_bit'? kbuild test robot
@ 2017-12-06  0:09 ` Andrew Morton
  2017-12-06  8:42   ` Geert Uytterhoeven
  0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2017-12-06  0:09 UTC (permalink / raw)
  To: kbuild test robot
  Cc: Clement Courbet, kbuild-all, Linux Memory Management List,
	Geert Uytterhoeven

On Tue, 5 Dec 2017 20:31:28 +0800 kbuild test robot <fengguang.wu@intel.com> wrote:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   7ceb97a071e80f1b5e4cd5a36de135612a836388
> commit: e49c614e6b37254b1e7bf55c631ce3cb5e3b6433 [2148/2944] lib: optimize cpumask_next_and()
> config: m68k-allmodconfig (attached as .config)
> compiler: m68k-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout e49c614e6b37254b1e7bf55c631ce3cb5e3b6433
>         # save the attached .config to linux build tree
>         make.cross ARCH=m68k 
> 
> All errors (new ones prefixed by >>):
> 
>    lib/find_bit_benchmark.c: In function 'test_find_next_and_bit':
> >> lib/find_bit_benchmark.c:115:7: error: implicit declaration of function 'find_next_and_bit'; did you mean 'find_next_bit'? [-Werror=implicit-function-declaration]
>       i = find_next_and_bit(bitmap, bitmap2, BITMAP_LEN, i+1);
>           ^~~~~~~~~~~~~~~~~
>           find_next_bit
>    cc1: some warnings being treated as errors

For some reason m68k doesn't include asm-generic/bitops/find.h from
arch/m68k/include/asm/bitops.h.  One for Clement and Geert to puzzle
out, please.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [linux-next:master 2148/2944] lib/find_bit_benchmark.c:115:7: error: implicit declaration of function 'find_next_and_bit'; did you mean 'find_next_bit'?
  2017-12-06  0:09 ` Andrew Morton
@ 2017-12-06  8:42   ` Geert Uytterhoeven
  0 siblings, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2017-12-06  8:42 UTC (permalink / raw)
  To: Andrew Morton
  Cc: kbuild test robot, Clement Courbet, kbuild-all,
	Linux Memory Management List

Hi Andrew,

On Wed, Dec 6, 2017 at 1:09 AM, Andrew Morton <akpm@linux-foundation.org> wrote:
> On Tue, 5 Dec 2017 20:31:28 +0800 kbuild test robot <fengguang.wu@intel.com> wrote:
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
>> head:   7ceb97a071e80f1b5e4cd5a36de135612a836388
>> commit: e49c614e6b37254b1e7bf55c631ce3cb5e3b6433 [2148/2944] lib: optimize cpumask_next_and()
>> config: m68k-allmodconfig (attached as .config)
>> compiler: m68k-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
>> reproduce:
>>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>>         chmod +x ~/bin/make.cross
>>         git checkout e49c614e6b37254b1e7bf55c631ce3cb5e3b6433
>>         # save the attached .config to linux build tree
>>         make.cross ARCH=m68k
>>
>> All errors (new ones prefixed by >>):
>>
>>    lib/find_bit_benchmark.c: In function 'test_find_next_and_bit':
>> >> lib/find_bit_benchmark.c:115:7: error: implicit declaration of function 'find_next_and_bit'; did you mean 'find_next_bit'? [-Werror=implicit-function-declaration]
>>       i = find_next_and_bit(bitmap, bitmap2, BITMAP_LEN, i+1);
>>           ^~~~~~~~~~~~~~~~~
>>           find_next_bit
>>    cc1: some warnings being treated as errors
>
> For some reason m68k doesn't include asm-generic/bitops/find.h from
> arch/m68k/include/asm/bitops.h.  One for Clement and Geert to puzzle
> out, please.

Oh it does, but only for the CONFIG_CPU_HAS_NO_BITFIELDS=y case.
Which used to be fine, as the code for CONFIG_CPU_HAS_NO_BITFIELDS=n
implemented everything in find.h, until find_next_and_bit() was added.

Thanks, will fix...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-12-06  8:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-05 12:31 [linux-next:master 2148/2944] lib/find_bit_benchmark.c:115:7: error: implicit declaration of function 'find_next_and_bit'; did you mean 'find_next_bit'? kbuild test robot
2017-12-06  0:09 ` Andrew Morton
2017-12-06  8:42   ` Geert Uytterhoeven

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox