Re: [PATCH v18 10/10] virtio-balloon: don't report free pages when page poisoning is enabled

[Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>]

Wei Wang wrote:
> @@ -652,7 +652,9 @@ static void report_free_page(struct work_struct *work)
>  	/* Start by sending the obtained cmd id to the host with an outbuf */
>  	send_one_desc(vb, vb->free_page_vq, virt_to_phys(&vb->start_cmd_id),
>  		      sizeof(uint32_t), false, true, false);
> -	walk_free_mem_block(vb, 0, &virtio_balloon_send_free_pages);
> +	if (!(page_poisoning_enabled() &&
> +	    !IS_ENABLED(CONFIG_PAGE_POISONING_NO_SANITY)))

I think that checking IS_ENABLED() before checking page_poisoning_enabled()
would generate better code, for IS_ENABLED() is build-time constant while
page_poisoning_enabled() is a function which the compiler assumes that we
need to call page_poisoning_enabled() even if IS_ENABLED() is known to be 0.

	if (IS_ENABLED(CONFIG_PAGE_POISONING_NO_SANITY) ||
	    !page_poisoning_enabled())

> +		walk_free_mem_block(vb, 0, &virtio_balloon_send_free_pages);
>  	/*
>  	 * End by sending the stop id to the host with an outbuf. Use the
>  	 * non-batching mode here to trigger a kick after adding the stop id.
> -- 
> 2.7.4

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>