From: Michal Hocko <mhocko@kernel.org>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
Roman Gushchin <guro@fb.com>,
David Rientjes <rientjes@google.com>,
Johannes Weiner <hannes@cmpxchg.org>, Tejun Heo <tj@kernel.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [PATCH v2] mm,oom: Set ->signal->oom_mm to all thread groups sharing the victim's mm.
Date: Tue, 28 Nov 2017 20:39:40 +0100 [thread overview]
Message-ID: <20171128193940.hcrsx3wimr5hwulh@dhcp22.suse.cz> (raw)
In-Reply-To: <1511885835-4899-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp>
On Wed 29-11-17 01:17:15, Tetsuo Handa wrote:
> Due to commit 696453e66630ad45 ("mm, oom: task_will_free_mem should skip
> oom_reaped tasks") and patch "mm,oom: Use ALLOC_OOM for OOM victim's last
> second allocation.", thread groups sharing the OOM victim's mm without
> setting ->signal->oom_mm before task_will_free_mem(current) is called
> might fail to try ALLOC_OOM allocation attempt.
I've already NACKed your previous attempt. Now you are interfering with
the patchset Roman plans to resubmit and cause further potential clashes
for him.
Stop this already!
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2017-11-28 19:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 12:41 [PATCH] " Tetsuo Handa
2017-11-28 13:00 ` Michal Hocko
2017-11-28 14:07 ` Tetsuo Handa
2017-11-28 16:17 ` [PATCH v2] " Tetsuo Handa
2017-11-28 19:39 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171128193940.hcrsx3wimr5hwulh@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=rientjes@google.com \
--cc=tj@kernel.org \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox