linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: linux-kernel@vger.kernel.org
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
	Andy Lutomirski <luto@kernel.org>, Ingo Molnar <mingo@kernel.org>,
	Borislav Petkov <bp@alien8.de>, Brian Gerst <brgerst@gmail.com>,
	Denys Vlasenko <dvlasenk@redhat.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Josh Poimboeuf <jpoimboe@redhat.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Rik van Riel <riel@redhat.com>,
	daniel.gruss@iaik.tugraz.at, hughd@google.com,
	keescook@google.com, linux-mm@kvack.org,
	michael.schwarz@iaik.tugraz.at, moritz.lipp@iaik.tugraz.at,
	richard.fellner@student.tugraz.at
Subject: [PATCH 4/5] x86/mm/kaiser: Remove superfluous SWITCH_TO_KERNEL
Date: Mon, 27 Nov 2017 23:31:14 +0100	[thread overview]
Message-ID: <20171127223405.329572992@infradead.org> (raw)
In-Reply-To: <20171127223110.479550152@infradead.org>

[-- Attachment #1: peterz-kaiser-fixup-syscall-switch.patch --]
[-- Type: text/plain, Size: 1044 bytes --]

We never use this code-path with KAISER enabled.

Fixes: ("Prepare the x86/entry assembly code for entry/exit CR3 switching")
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
---
 arch/x86/entry/entry_64.S |    8 --------
 1 file changed, 8 deletions(-)

--- a/arch/x86/entry/entry_64.S
+++ b/arch/x86/entry/entry_64.S
@@ -201,14 +201,6 @@ ENTRY(entry_SYSCALL_64)
 
 	swapgs
 	movq	%rsp, PER_CPU_VAR(rsp_scratch)
-
-	/*
-	 * The kernel CR3 is needed to map the process stack, but we
-	 * need a scratch register to be able to load CR3.  %rsp is
-	 * clobberable right now, so use it as a scratch register.
-	 * %rsp will look crazy here for a couple instructions.
-	 */
-	SWITCH_TO_KERNEL_CR3 scratch_reg=%rsp
 	movq	PER_CPU_VAR(cpu_current_top_of_stack), %rsp
 
 	/* Construct struct pt_regs on stack */


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2017-11-27 22:35 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-27 22:31 [PATCH 0/5] KAISER fixlets Peter Zijlstra
2017-11-27 22:31 ` [PATCH 1/5] x86/mm/kaiser: Alternative ESPFIX Peter Zijlstra
2017-11-27 22:39   ` Peter Zijlstra
2017-11-27 22:41   ` Dave Hansen
2017-11-27 22:31 ` [PATCH 2/5] x86/mm/kaiser: Add a banner Peter Zijlstra
2017-11-28  3:36   ` Andy Lutomirski
2017-11-28  5:03     ` Josh Poimboeuf
2017-11-28  5:23       ` Andy Lutomirski
2017-11-28 12:54     ` Borislav Petkov
2017-11-27 22:31 ` [PATCH 3/5] x86/mm/kaiser: Revert ("Map the entry stack variables") Peter Zijlstra
2017-11-27 22:31 ` Peter Zijlstra [this message]
2017-11-27 22:47   ` [PATCH 4/5] x86/mm/kaiser: Remove superfluous SWITCH_TO_KERNEL Dave Hansen
2017-11-27 22:53     ` Peter Zijlstra
2017-11-27 22:31 ` [PATCH 5/5] x86/mm/kaiser: Disable the SYSCALL-64 trampoline along with KAISER Peter Zijlstra
2017-11-27 22:53   ` Dave Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171127223405.329572992@infradead.org \
    --to=peterz@infradead.org \
    --cc=bp@alien8.de \
    --cc=brgerst@gmail.com \
    --cc=daniel.gruss@iaik.tugraz.at \
    --cc=dave.hansen@linux.intel.com \
    --cc=dvlasenk@redhat.com \
    --cc=hpa@zytor.com \
    --cc=hughd@google.com \
    --cc=jpoimboe@redhat.com \
    --cc=keescook@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=luto@kernel.org \
    --cc=michael.schwarz@iaik.tugraz.at \
    --cc=mingo@kernel.org \
    --cc=moritz.lipp@iaik.tugraz.at \
    --cc=richard.fellner@student.tugraz.at \
    --cc=riel@redhat.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox