From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot0-f198.google.com (mail-ot0-f198.google.com [74.125.82.198]) by kanga.kvack.org (Postfix) with ESMTP id 0027C6B0261 for ; Mon, 27 Nov 2017 16:11:18 -0500 (EST) Received: by mail-ot0-f198.google.com with SMTP id f28so16386465otd.12 for ; Mon, 27 Nov 2017 13:11:17 -0800 (PST) Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id b83sor4713639oia.70.2017.11.27.13.11.17 for (Google Transport Security); Mon, 27 Nov 2017 13:11:17 -0800 (PST) Date: Mon, 27 Nov 2017 13:11:14 -0800 From: Guenter Roeck Subject: Re: mm/percpu.c: use smarter memory allocation for struct pcpu_alloc_info (crisv32 hang) Message-ID: <20171127211114.GA23806@roeck-us.net> References: <20171118182542.GA23928@roeck-us.net> <20171127194105.GM983427@devbig577.frc2.facebook.com> <20171127203335.GQ983427@devbig577.frc2.facebook.com> <20171127205421.GR983427@devbig577.frc2.facebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171127205421.GR983427@devbig577.frc2.facebook.com> Sender: owner-linux-mm@kvack.org List-ID: To: Tejun Heo Cc: Nicolas Pitre , Christoph Lameter , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Mikael Starvik , Jesper Nilsson , linux-cris-kernel@axis.com On Mon, Nov 27, 2017 at 12:54:21PM -0800, Tejun Heo wrote: > Hello, Nicolas. > > On Mon, Nov 27, 2017 at 03:51:04PM -0500, Nicolas Pitre wrote: > > Subject: percpu: hack to let the CRIS architecture to boot until they clean up > > > > Commit 438a506180 ("percpu: don't forget to free the temporary struct > > pcpu_alloc_info") uncovered a problem on the CRIS architecture where > > the bootmem allocator is initialized with virtual addresses. Given it > > has: > > > > #define __va(x) ((void *)((unsigned long)(x) | 0x80000000)) > > > > then things just work out because the end result is the same whether you > > give this a physical or a virtual address. > > > > Untill you call memblock_free_early(__pa(address)) that is, because > > values from __pa() don't match with the virtual addresses stuffed in the > > bootmem allocator anymore. > > > > Avoid freeing the temporary pcpu_alloc_info memory on that architecture > > until they fix things up to let the kernel boot like it did before. > > > > Signed-off-by: Nicolas Pitre > > This totally works for me. Replaced the revert with this one. > Same here. Thanks, Guenter > Thanks! > > -- > tejun -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org