[linux-next:master 13808/14071] arch/arm/include/asm/pgtable-3level.h:228:25: note: in expansion of macro 'pmd_write'

[linux-next:master 13808/14071] arch/arm/include/asm/pgtable-3level.h:228:25: note: in expansion of macro 'pmd_write'

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 4001 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   aa1fbe633d3034f9f838ff13387af04771e68e31
commit: 5292abe86ee6b74a475d33d38bf5a266dacece0b [13808/14071] mm: fix device-dax pud write-faults triggered by get_user_pages()
config: arm-axm55xx_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 5292abe86ee6b74a475d33d38bf5a266dacece0b
        # save the attached .config to linux build tree
        make.cross ARCH=arm 

All error/warnings (new ones prefixed by >>):

   In file included from arch/arm/include/asm/pgtable.h:32:0,
                    from include/linux/memremap.h:8,
                    from include/linux/mm.h:27,
                    from arch/arm/kernel/asm-offsets.c:15:
>> arch/arm/include/asm/pgtable-3level.h:212:32: error: expected identifier or '(' before '!' token
    #define pmd_isclear(pmd, val) (!(pmd_val(pmd) & (val)))
                                   ^
>> arch/arm/include/asm/pgtable-3level.h:225:26: note: in expansion of macro 'pmd_isclear'
    #define pmd_write(pmd)  (pmd_isclear((pmd), L_PMD_SECT_RDONLY))
                             ^~~~~~~~~~~
>> arch/arm/include/asm/pgtable-3level.h:228:25: note: in expansion of macro 'pmd_write'
    #define pud_write(pud)  pmd_write(__pmd(pud_val(pud)))
                            ^~~~~~~~~
   include/asm-generic/pgtable.h:817:19: note: in expansion of macro 'pud_write'
    static inline int pud_write(pud_t pud)
                      ^~~~~~~~~
   make[2]: *** [arch/arm/kernel/asm-offsets.s] Error 1
   make[2]: Target '__build' not remade because of errors.
   make[1]: *** [prepare0] Error 2
   make[1]: Target 'prepare' not remade because of errors.
   make: *** [sub-make] Error 2

vim +/pmd_write +228 arch/arm/include/asm/pgtable-3level.h

1355e2a6 Catalin Marinas 2012-07-25  209  
f2950706 Steven Capper   2014-07-18  210  #define pmd_isset(pmd, val)	((u32)(val) == (val) ? pmd_val(pmd) & (val) \
f2950706 Steven Capper   2014-07-18  211  						: !!(pmd_val(pmd) & (val)))
f2950706 Steven Capper   2014-07-18 @212  #define pmd_isclear(pmd, val)	(!(pmd_val(pmd) & (val)))
f2950706 Steven Capper   2014-07-18  213  
62453188 Will Deacon     2016-06-07  214  #define pmd_present(pmd)	(pmd_isset((pmd), L_PMD_SECT_VALID))
f2950706 Steven Capper   2014-07-18  215  #define pmd_young(pmd)		(pmd_isset((pmd), PMD_SECT_AF))
bd951303 Steve Capper    2014-10-09  216  #define pte_special(pte)	(pte_isset((pte), L_PTE_SPECIAL))
bd951303 Steve Capper    2014-10-09  217  static inline pte_t pte_mkspecial(pte_t pte)
bd951303 Steve Capper    2014-10-09  218  {
bd951303 Steve Capper    2014-10-09  219  	pte_val(pte) |= L_PTE_SPECIAL;
bd951303 Steve Capper    2014-10-09  220  	return pte;
bd951303 Steve Capper    2014-10-09  221  }
bd951303 Steve Capper    2014-10-09  222  #define	__HAVE_ARCH_PTE_SPECIAL
8d962507 Catalin Marinas 2012-07-25  223  
8d962507 Catalin Marinas 2012-07-25  224  #define __HAVE_ARCH_PMD_WRITE
ded94779 Steven Capper   2014-07-18 @225  #define pmd_write(pmd)		(pmd_isclear((pmd), L_PMD_SECT_RDONLY))
ded94779 Steven Capper   2014-07-18  226  #define pmd_dirty(pmd)		(pmd_isset((pmd), L_PMD_SECT_DIRTY))
b8cd51af Steve Capper    2014-10-09  227  #define pud_page(pud)		pmd_page(__pmd(pud_val(pud)))
b8cd51af Steve Capper    2014-10-09 @228  #define pud_write(pud)		pmd_write(__pmd(pud_val(pud)))
8d962507 Catalin Marinas 2012-07-25  229  

:::::: The code at line 228 was first introduced by commit
:::::: b8cd51afe05a98ef907e61c603d5c5b7ad6242d8 arm: mm: enable RCU fast_gup

:::::: TO: Steve Capper <steve.capper@linaro.org>
:::::: CC: Linus Torvalds <torvalds@linux-foundation.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 20335 bytes --]

Re: [linux-next:master 13808/14071] arch/arm/include/asm/pgtable-3level.h:228:25: note: in expansion of macro 'pmd_write'

[Dan Williams]

On Wed, Nov 22, 2017 at 8:44 AM, kbuild test robot
<fengguang.wu@intel.com> wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   aa1fbe633d3034f9f838ff13387af04771e68e31
> commit: 5292abe86ee6b74a475d33d38bf5a266dacece0b [13808/14071] mm: fix device-dax pud write-faults triggered by get_user_pages()
> config: arm-axm55xx_defconfig (attached as .config)
> compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout 5292abe86ee6b74a475d33d38bf5a266dacece0b
>         # save the attached .config to linux build tree
>         make.cross ARCH=arm
>
> All error/warnings (new ones prefixed by >>):
>
>    In file included from arch/arm/include/asm/pgtable.h:32:0,
>                     from include/linux/memremap.h:8,
>                     from include/linux/mm.h:27,
>                     from arch/arm/kernel/asm-offsets.c:15:
>>> arch/arm/include/asm/pgtable-3level.h:212:32: error: expected identifier or '(' before '!' token
>     #define pmd_isclear(pmd, val) (!(pmd_val(pmd) & (val)))
>                                    ^
>>> arch/arm/include/asm/pgtable-3level.h:225:26: note: in expansion of macro 'pmd_isclear'
>     #define pmd_write(pmd)  (pmd_isclear((pmd), L_PMD_SECT_RDONLY))
>                              ^~~~~~~~~~~
>>> arch/arm/include/asm/pgtable-3level.h:228:25: note: in expansion of macro 'pmd_write'
>     #define pud_write(pud)  pmd_write(__pmd(pud_val(pud)))
>                             ^~~~~~~~~
>    include/asm-generic/pgtable.h:817:19: note: in expansion of macro 'pud_write'
>     static inline int pud_write(pud_t pud)
>                       ^~~~~~~~~
>    make[2]: *** [arch/arm/kernel/asm-offsets.s] Error 1
>    make[2]: Target '__build' not remade because of errors.
>    make[1]: *** [prepare0] Error 2
>    make[1]: Target 'prepare' not remade because of errors.
>    make: *** [sub-make] Error 2

The build succeeds for me when this commit is based on top of mainline
at commit:

    a3841f94c7ec Merge tag 'libnvdimm-for-4.15' of
git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm

...so something in -next causes this to fail. I'll take a look.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>