From: Andrew Morton <akpm@linux-foundation.org>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: linux-mm@kvack.org, Dave Chinner <david@fromorbit.com>,
Al Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.com>,
Paolo Bonzini <pbonzini@redhat.com>,
David Airlie <airlied@linux.ie>,
Alex Deucher <alexander.deucher@amd.com>,
Shaohua Li <shli@fb.com>, Mike Snitzer <snitzer@redhat.com>
Subject: Re: [PATCH] mm,vmscan: Mark register_shrinker() as __must_check
Date: Tue, 21 Nov 2017 13:40:07 -0800 [thread overview]
Message-ID: <20171121134007.466815aa4a0562eaaa223cbf@linux-foundation.org> (raw)
In-Reply-To: <1511265757-15563-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp>
On Tue, 21 Nov 2017 21:02:37 +0900 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> wrote:
> There are users not checking for register_shrinker() failure.
> Continuing with ignoring failure can lead to later oops at
> unregister_shrinker().
>
> ...
>
> --- a/include/linux/shrinker.h
> +++ b/include/linux/shrinker.h
> @@ -75,6 +75,6 @@ struct shrinker {
> #define SHRINKER_NUMA_AWARE (1 << 0)
> #define SHRINKER_MEMCG_AWARE (1 << 1)
>
> -extern int register_shrinker(struct shrinker *);
> +extern __must_check int register_shrinker(struct shrinker *);
> extern void unregister_shrinker(struct shrinker *);
> #endif
hm, well, OK, it's a small kmalloc(GFP_KERNEL). That won't be
failing.
Affected code seems to be fs/xfs, fs/super.c, fs/quota,
arch/x86/kvm/mmu, drivers/gpu/drm/ttm, drivers/md and a bunch of
staging stuff.
I'm not sure this is worth bothering about?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-11-21 21:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-21 12:02 Tetsuo Handa
2017-11-21 21:40 ` Andrew Morton [this message]
2017-11-21 22:09 ` Tetsuo Handa
2017-11-22 10:53 ` Tetsuo Handa
2017-11-22 12:45 ` Michal Hocko
2017-11-22 13:06 ` Tetsuo Handa
2017-11-22 14:31 ` Paolo Bonzini
2017-11-22 14:36 ` Michal Hocko
2017-11-22 20:39 ` Dave Chinner
2017-11-23 6:34 ` Tetsuo Handa
2017-11-23 8:02 ` Michal Hocko
2017-11-23 9:21 ` Paolo Bonzini
2017-11-23 9:56 ` Tetsuo Handa
2017-11-23 10:02 ` Michal Hocko
2017-11-23 10:38 ` Tetsuo Handa
2017-11-23 10:43 ` Paolo Bonzini
2017-11-23 11:03 ` Tetsuo Handa
2017-11-22 12:33 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171121134007.466815aa4a0562eaaa223cbf@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=david@fromorbit.com \
--cc=jack@suse.com \
--cc=linux-mm@kvack.org \
--cc=pbonzini@redhat.com \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=shli@fb.com \
--cc=snitzer@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox