* [PATCH v3] virtio_balloon: include disk/file caches memory statistics
@ 2017-11-12 12:05 Tomáš Golembiovský
2017-11-20 14:06 ` Tomáš Golembiovský
2017-11-29 1:24 ` Michael S. Tsirkin
0 siblings, 2 replies; 3+ messages in thread
From: Tomáš Golembiovský @ 2017-11-12 12:05 UTC (permalink / raw)
To: linux-mm, virtio-dev, qemu-devel, kvm, virtualization
Cc: Huang Ying, Gal Hammer, Michael S. Tsirkin, Jason Wang,
Amnon Ilan, Wei Wang, Shaohua Li, Rik van Riel,
Tomáš Golembiovský
Add a new field VIRTIO_BALLOON_S_CACHES to virtio_balloon memory
statistics protocol. The value represents all disk/file caches.
In this case it corresponds to the sum of values
Buffers+Cached+SwapCached from /proc/meminfo.
Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com>
---
drivers/virtio/virtio_balloon.c | 4 ++++
include/uapi/linux/virtio_balloon.h | 3 ++-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
index f0b3a0b9d42f..d2bd13bbaf9f 100644
--- a/drivers/virtio/virtio_balloon.c
+++ b/drivers/virtio/virtio_balloon.c
@@ -244,11 +244,13 @@ static unsigned int update_balloon_stats(struct virtio_balloon *vb)
struct sysinfo i;
unsigned int idx = 0;
long available;
+ unsigned long caches;
all_vm_events(events);
si_meminfo(&i);
available = si_mem_available();
+ caches = global_node_page_state(NR_FILE_PAGES);
#ifdef CONFIG_VM_EVENT_COUNTERS
update_stat(vb, idx++, VIRTIO_BALLOON_S_SWAP_IN,
@@ -264,6 +266,8 @@ static unsigned int update_balloon_stats(struct virtio_balloon *vb)
pages_to_bytes(i.totalram));
update_stat(vb, idx++, VIRTIO_BALLOON_S_AVAIL,
pages_to_bytes(available));
+ update_stat(vb, idx++, VIRTIO_BALLOON_S_CACHES,
+ pages_to_bytes(caches));
return idx;
}
diff --git a/include/uapi/linux/virtio_balloon.h b/include/uapi/linux/virtio_balloon.h
index 343d7ddefe04..4e8b8304b793 100644
--- a/include/uapi/linux/virtio_balloon.h
+++ b/include/uapi/linux/virtio_balloon.h
@@ -52,7 +52,8 @@ struct virtio_balloon_config {
#define VIRTIO_BALLOON_S_MEMFREE 4 /* Total amount of free memory */
#define VIRTIO_BALLOON_S_MEMTOT 5 /* Total amount of memory */
#define VIRTIO_BALLOON_S_AVAIL 6 /* Available memory as in /proc */
-#define VIRTIO_BALLOON_S_NR 7
+#define VIRTIO_BALLOON_S_CACHES 7 /* Disk caches */
+#define VIRTIO_BALLOON_S_NR 8
/*
* Memory statistics structure.
--
2.15.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v3] virtio_balloon: include disk/file caches memory statistics
2017-11-12 12:05 [PATCH v3] virtio_balloon: include disk/file caches memory statistics Tomáš Golembiovský
@ 2017-11-20 14:06 ` Tomáš Golembiovský
2017-11-29 1:24 ` Michael S. Tsirkin
1 sibling, 0 replies; 3+ messages in thread
From: Tomáš Golembiovský @ 2017-11-20 14:06 UTC (permalink / raw)
To: linux-mm, virtio-dev, qemu-devel, kvm, virtualization
Cc: Huang Ying, Gal Hammer, Michael S. Tsirkin, Jason Wang,
Amnon Ilan, Wei Wang, Shaohua Li, Rik van Riel
On Sun, 12 Nov 2017 13:05:38 +0100
Tomáš Golembiovský <tgolembi@redhat.com> wrote:
> Add a new field VIRTIO_BALLOON_S_CACHES to virtio_balloon memory
> statistics protocol. The value represents all disk/file caches.
>
> In this case it corresponds to the sum of values
> Buffers+Cached+SwapCached from /proc/meminfo.
>
> Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com>
> ---
> drivers/virtio/virtio_balloon.c | 4 ++++
> include/uapi/linux/virtio_balloon.h | 3 ++-
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
ping
--
Tomáš Golembiovský <tgolembi@redhat.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] virtio_balloon: include disk/file caches memory statistics
2017-11-12 12:05 [PATCH v3] virtio_balloon: include disk/file caches memory statistics Tomáš Golembiovský
2017-11-20 14:06 ` Tomáš Golembiovský
@ 2017-11-29 1:24 ` Michael S. Tsirkin
1 sibling, 0 replies; 3+ messages in thread
From: Michael S. Tsirkin @ 2017-11-29 1:24 UTC (permalink / raw)
To: Tomáš Golembiovský
Cc: linux-mm, virtio-dev, qemu-devel, kvm, virtualization,
Huang Ying, Gal Hammer, Jason Wang, Amnon Ilan, Wei Wang,
Shaohua Li, Rik van Riel
On Sun, Nov 12, 2017 at 01:05:38PM +0100, TomA!A! GolembiovskA 1/2 wrote:
> Add a new field VIRTIO_BALLOON_S_CACHES to virtio_balloon memory
> statistics protocol. The value represents all disk/file caches.
>
> In this case it corresponds to the sum of values
> Buffers+Cached+SwapCached from /proc/meminfo.
>
> Signed-off-by: TomA!A! GolembiovskA 1/2 <tgolembi@redhat.com>
I parked this on vhost branch, part of linux next.
> ---
> drivers/virtio/virtio_balloon.c | 4 ++++
> include/uapi/linux/virtio_balloon.h | 3 ++-
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
> index f0b3a0b9d42f..d2bd13bbaf9f 100644
> --- a/drivers/virtio/virtio_balloon.c
> +++ b/drivers/virtio/virtio_balloon.c
> @@ -244,11 +244,13 @@ static unsigned int update_balloon_stats(struct virtio_balloon *vb)
> struct sysinfo i;
> unsigned int idx = 0;
> long available;
> + unsigned long caches;
>
> all_vm_events(events);
> si_meminfo(&i);
>
> available = si_mem_available();
> + caches = global_node_page_state(NR_FILE_PAGES);
>
> #ifdef CONFIG_VM_EVENT_COUNTERS
> update_stat(vb, idx++, VIRTIO_BALLOON_S_SWAP_IN,
> @@ -264,6 +266,8 @@ static unsigned int update_balloon_stats(struct virtio_balloon *vb)
> pages_to_bytes(i.totalram));
> update_stat(vb, idx++, VIRTIO_BALLOON_S_AVAIL,
> pages_to_bytes(available));
> + update_stat(vb, idx++, VIRTIO_BALLOON_S_CACHES,
> + pages_to_bytes(caches));
>
> return idx;
> }
> diff --git a/include/uapi/linux/virtio_balloon.h b/include/uapi/linux/virtio_balloon.h
> index 343d7ddefe04..4e8b8304b793 100644
> --- a/include/uapi/linux/virtio_balloon.h
> +++ b/include/uapi/linux/virtio_balloon.h
> @@ -52,7 +52,8 @@ struct virtio_balloon_config {
> #define VIRTIO_BALLOON_S_MEMFREE 4 /* Total amount of free memory */
> #define VIRTIO_BALLOON_S_MEMTOT 5 /* Total amount of memory */
> #define VIRTIO_BALLOON_S_AVAIL 6 /* Available memory as in /proc */
> -#define VIRTIO_BALLOON_S_NR 7
> +#define VIRTIO_BALLOON_S_CACHES 7 /* Disk caches */
> +#define VIRTIO_BALLOON_S_NR 8
>
> /*
> * Memory statistics structure.
> --
> 2.15.0
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-29 1:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-12 12:05 [PATCH v3] virtio_balloon: include disk/file caches memory statistics Tomáš Golembiovský
2017-11-20 14:06 ` Tomáš Golembiovský
2017-11-29 1:24 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox