linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@suse.com>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: Andrea Arcangeli <aarcange@redhat.com>,
	akpm@linux-foundation.org, linux-mm@kvack.org,
	Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH] mm,page_alloc: Use min watermark for last second allocation attempt.
Date: Mon, 20 Nov 2017 10:38:51 +0100	[thread overview]
Message-ID: <20171120093851.gs3zqpmmyacxplor@dhcp22.suse.cz> (raw)
In-Reply-To: <1510915081-3768-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp>

On Fri 17-11-17 19:38:01, Tetsuo Handa wrote:
[...]
> [ 1792.835056] Out of memory: Kill process 14294 (idle-priority) score 876 or sacrifice child
> [ 1792.836073] Killed process 14458 (normal-priority) total-vm:4176kB, anon-rss:88kB, file-rss:0kB, shmem-rss:0kB

Wen you are in a situation when you are killing 88kB process then you
are most probably going to suffer more oom kills anyway. Optimizing for
this case is thus questionable at best. You would need to come up with
a reasonable explanation why the livelock as described by Andrea is not
possible with the current MM reclaim retry implementation. I am not
saying the patch is wrong but your justification _is_ wrong.
-- 
Michal Hocko
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2017-11-20  9:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-17 10:38 Tetsuo Handa
2017-11-20  9:38 ` Michal Hocko [this message]
2017-11-25 11:07   ` Tetsuo Handa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171120093851.gs3zqpmmyacxplor@dhcp22.suse.cz \
    --to=mhocko@suse.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-mm@kvack.org \
    --cc=penguin-kernel@I-love.SAKURA.ne.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox