From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f69.google.com (mail-pg0-f69.google.com [74.125.83.69]) by kanga.kvack.org (Postfix) with ESMTP id C032D6B0033 for ; Tue, 14 Nov 2017 07:48:36 -0500 (EST) Received: by mail-pg0-f69.google.com with SMTP id r12so9145677pgu.9 for ; Tue, 14 Nov 2017 04:48:36 -0800 (PST) Received: from mx0a-00082601.pphosted.com (mx0b-00082601.pphosted.com. [67.231.153.30]) by mx.google.com with ESMTPS id b21si15366895pfe.291.2017.11.14.04.48.34 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Nov 2017 04:48:35 -0800 (PST) Date: Tue, 14 Nov 2017 12:48:07 +0000 From: Roman Gushchin Subject: Re: [PATCH] mm: show stats for non-default hugepage sizes in /proc/meminfo Message-ID: <20171114124800.GA5321@castle> References: <20171113160302.14409-1-guro@fb.com> <8aa63aee-cbbb-7516-30cf-15fcf925060b@intel.com> <20171113181105.GA27034@castle> <2579a26d-81d1-732e-ef57-33bb4c293cd6@oracle.com> <20171113184454.GA18531@castle> <20171113191056.GA28749@cmpxchg.org> <0842738c-1c6f-9a29-b9a6-21e5af898c31@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <0842738c-1c6f-9a29-b9a6-21e5af898c31@oracle.com> Sender: owner-linux-mm@kvack.org List-ID: To: Mike Kravetz Cc: Johannes Weiner , Dave Hansen , linux-mm@kvack.org, Andrew Morton , Michal Hocko , "Aneesh Kumar K.V" , Andrea Arcangeli , kernel-team@fb.com, linux-kernel@vger.kernel.org On Mon, Nov 13, 2017 at 11:25:21AM -0800, Mike Kravetz wrote: > On 11/13/2017 11:10 AM, Johannes Weiner wrote: > > On Mon, Nov 13, 2017 at 06:45:01PM +0000, Roman Gushchin wrote: > >> Or, at least, some total counter, e.g. how much memory is consumed > >> by hugetlb pages? > > > > I'm not a big fan of the verbose breakdown for every huge page size. > > As others have pointed out such detail exists elswhere. > > > > But I do think we should have a summary counter for memory consumed by > > hugetlb that lets you know how much is missing from MemTotal. This can > > be large parts of overall memory, and right now /proc/meminfo will > > give the impression we are leaking those pages. > > > > Maybe a simple summary counter for everything set aside by the hugetlb > > subsystem - default and non-default page sizes, whether they're used > > or only reserved etc.? > > > > Hugetlb 12345 kB > > I would prefer this approach. The 'trick' is coming up with a name or > description that is not confusing. Unfortunately, we have to leave the > existing entries. So, this new entry will be greater than or equal to > HugePages_Total. :( I guess Hugetlb is as good of a name as any? Yes, I like this approach too, and Hugetlb (in kB) sounds reasonable. I'll post a new patch soon. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org