From: Mel Gorman <mgorman@suse.de>
To: Jan Kara <jack@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org
Subject: Re: [PATCH] mm, truncate: remove all exceptional entries from pagevec under one lock -fix
Date: Wed, 8 Nov 2017 16:59:46 +0000 [thread overview]
Message-ID: <20171108165946.3psvkgya5xq5srrf@suse.de> (raw)
In-Reply-To: <20171108164226.26788-1-jack@suse.cz>
On Wed, Nov 08, 2017 at 05:42:26PM +0100, Jan Kara wrote:
> Patch "mm, truncate: remove all exceptional entries from pagevec" had a
> problem that truncate_exceptional_pvec_entries() didn't remove exceptional
> entries that were beyond end of truncated range from the pagevec. As a result
> pagevec_release() oopsed trying to treat exceptional entry as a page pointer.
> This can be reproduced by running xfstests generic/269 in a loop while
> applying memory pressure until the bug triggers.
>
> Rip out fragile passing of index of the first exceptional entry in the
> pagevec and scan the full pagevec instead. Additional pagevec pass doesn't
> have measurable overhead and the code is more robust that way.
>
> This is a fix to the mmotm patch
> mm-truncate-remove-all-exceptional-entries-from-pagevec-under-one-lock.patch
>
> Signed-off-by: Jan Kara <jack@suse.cz>
>
Acked-by: Mel Gorman <mgorman@suse.com>
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2017-11-08 16:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-08 16:42 Jan Kara
2017-11-08 16:59 ` Mel Gorman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171108165946.3psvkgya5xq5srrf@suse.de \
--to=mgorman@suse.de \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox