linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@kernel.org>
To: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: linux-mm@kvack.org
Subject: Re: Guaranteed allocation of huge pages (1G) using movablecore=N doesn't seem to work at all
Date: Mon, 6 Nov 2017 19:04:06 +0100	[thread overview]
Message-ID: <20171106180406.diowlwanvucnwkbp@dhcp22.suse.cz> (raw)
In-Reply-To: <CACAwPwYp4TysdH_1w1F9L7BpwFAGR8dNg04F6QASyQeYYNErkg@mail.gmail.com>

On Mon 06-11-17 19:36:38, Maxim Levitsky wrote:
> Isn't this a non backward compatible change? Why to remove an optional non
> default option for use cases like mine.

Well, strictly speaking it is. The reality is that with the current
implementation the option breaks the hotplug usecase. I can see your
argument about the opt in and we might need to hold on this patch for
merging uut it seems that http://lkml.kernel.org/r/20171003072619.8654-1-mhocko@kernel.org
is not the problem you are seeing.

> I won't argue with you on this, but my question was different, and was why
> the kernel can't move other pages from moveable zone in my case.

OK, I have re-read your original report where you say
: This was tested on 4.14.0-rc5 (my custom compiled) and on several
: older kernels (4.10,4.12,4.13) from ubuntu repositories.

Does that mean that this a new regression in 4.14-rc5 or you see the
problem in other kernels too?

If this a new rc5 thing then 79b63f12abcb ("mm, hugetlb: do not
allocate non-migrateable gigantic pages from movable zones") might be
related. Although it shouldn't if hugepages_treat_as_movable is enabled.

I wouldn't be all that surprised if this was an older issue, though. If
I look at pfn_range_valid_gigantic it seems that the page count check
makes it just too easy to fail even on migratable memory. To be honest
I consider the giga pages runtime support rather fragile and that is
why I wasn't very much afraid to remove hacks that allow breaking other
usecases.
-- 
Michal Hocko
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2017-11-06 18:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-04  9:55 Maxim Levitsky
2017-11-06 13:05 ` Michal Hocko
2017-11-06 17:03   ` Maxim Levitsky
2017-11-06 17:11     ` Michal Hocko
     [not found]       ` <CACAwPwZuiT9BfunVgy73KYjGfVopgcE0dknAxSLPNeJB8rkcMQ@mail.gmail.com>
     [not found]         ` <CACAwPwZqFRyFJhb7pyyrufah+1TfCDuzQMo3qwJuMKkp6aYd_Q@mail.gmail.com>
     [not found]           ` <CACAwPwbA0NpTC9bfV7ySHkxPrbZJVvjH=Be5_c25Q3S8qNay+w@mail.gmail.com>
     [not found]             ` <CACAwPwamD4RL9O8wujK_jCKGu=x0dBBmH9O-9078cUEEk4WsMA@mail.gmail.com>
     [not found]               ` <CACAwPwYKjK5RT-ChQqqUnD7PrtpXg1WhTHGK3q60i6StvDMDRg@mail.gmail.com>
     [not found]                 ` <CACAwPwav-eY4_nt=Z7TQB8WMFg+1X5WY2Gkgxph74X7=Ovfvrw@mail.gmail.com>
     [not found]                   ` <CACAwPwaP05FgxTp=kavwgFZF+LEGO-OSspJ4jH+Y=_uRxiVZaA@mail.gmail.com>
     [not found]                     ` <CACAwPwY5ss_D9kj7XoLVVkQ9=KXDFCnyDzdoxkGxhJZBNFre3w@mail.gmail.com>
2017-11-06 17:36                       ` Maxim Levitsky
2017-11-06 18:04                         ` Michal Hocko [this message]
2017-11-06 18:13                           ` Maxim Levitsky
2017-11-06 18:32                             ` Michal Hocko
2017-11-06 19:31                               ` Michal Hocko
2017-11-06 22:32                                 ` Maxim Levitsky
2017-11-07  8:20                               ` Vlastimil Babka
2017-11-07  8:30                                 ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171106180406.diowlwanvucnwkbp@dhcp22.suse.cz \
    --to=mhocko@kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=maximlevitsky@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox