From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f197.google.com (mail-pf0-f197.google.com [209.85.192.197]) by kanga.kvack.org (Postfix) with ESMTP id 8EDAF6B025F for ; Fri, 3 Nov 2017 09:57:43 -0400 (EDT) Received: by mail-pf0-f197.google.com with SMTP id x7so2830608pfa.19 for ; Fri, 03 Nov 2017 06:57:43 -0700 (PDT) Received: from mx2.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id k8si4928972pli.74.2017.11.03.06.57.42 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 03 Nov 2017 06:57:42 -0700 (PDT) Date: Fri, 3 Nov 2017 14:57:39 +0100 From: Michal Hocko Subject: Re: [PATCH] mm,page_alloc: Update comment for last second allocation attempt. Message-ID: <20171103135739.svmtesmgynshjuth@dhcp22.suse.cz> References: <201711022015.BBE95844.QOHtJFMLFOOSVF@I-love.SAKURA.ne.jp> <1509716789-7218-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1509716789-7218-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp> Sender: owner-linux-mm@kvack.org List-ID: To: Tetsuo Handa Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrea Arcangeli , Johannes Weiner On Fri 03-11-17 22:46:29, Tetsuo Handa wrote: [...] > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index c274960..547e9cb 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -3312,11 +3312,10 @@ void warn_alloc(gfp_t gfp_mask, nodemask_t *nodemask, const char *fmt, ...) > } > > /* > - * Go through the zonelist yet one more time, keep very high watermark > - * here, this is only to catch a parallel oom killing, we must fail if > - * we're still under heavy pressure. But make sure that this reclaim > - * attempt shall not depend on __GFP_DIRECT_RECLAIM && !__GFP_NORETRY > - * allocation which will never fail due to oom_lock already held. > + * This allocation attempt must not depend on __GFP_DIRECT_RECLAIM && > + * !__GFP_NORETRY allocation which will never fail due to oom_lock > + * already held. And since this allocation attempt does not sleep, > + * there is no reason we must use high watermark here. > */ > page = get_page_from_freelist((gfp_mask | __GFP_HARDWALL) & > ~__GFP_DIRECT_RECLAIM, order, Which patch does this depend on? -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org