From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f72.google.com (mail-oi0-f72.google.com [209.85.218.72]) by kanga.kvack.org (Postfix) with ESMTP id 845F06B0038 for ; Fri, 3 Nov 2017 06:11:10 -0400 (EDT) Received: by mail-oi0-f72.google.com with SMTP id f66so2331913oib.1 for ; Fri, 03 Nov 2017 03:11:10 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id 32si2837173otr.352.2017.11.03.03.11.09 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 03 Nov 2017 03:11:09 -0700 (PDT) Date: Fri, 3 Nov 2017 11:11:04 +0100 From: Karel Zak Subject: Re: [PATCH 0/3] lsmem/chmem: add memory zone awareness Message-ID: <20171103101104.kw6xoxust3r7f7v3@ws.net.home> References: <20170927174446.20459-1-gerald.schaefer@de.ibm.com> <20171018114009.7b4iax6536un5bnr@ws.net.home> <20171102175408.18d4eafc@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171102175408.18d4eafc@thinkpad> Sender: owner-linux-mm@kvack.org List-ID: To: Gerald Schaefer Cc: util-linux@vger.kernel.org, Michal Hocko , linux-mm , Heiko Carstens , Andre Wild On Thu, Nov 02, 2017 at 05:54:08PM +0100, Gerald Schaefer wrote: > Sorry for the late answer. I'm not sure if I understand the problem, it > "works as designed" that the range merging is done based on the output > columns, but I see that it was not really described as such. So I do > like the note that you added with the above mentioned commit. > > However, regarding the --split option, I think it may be confusing at > least for human users, if an "lsmem -oRANGE" will now print more than > one range, even if this is now based on a "fixed" set of default columns > that are used for merging (but "subject to change" according to the man > page). OK, I think we can support both concepts :-) I have modified lsmem to: - follow output columns for split policy by default (= your original implementation) - the --split is optional and may be used to override the default behavior it means for humans it's probably less concussing and advanced users may define by --split another way how to generate the ranges. I think it's good compromise and it's backwardly compatible with the previous version. OK? If yes, I need to backport this change to RHEL7.5 :-) > I also do not really see the benefit for script usage, at least if we > define it as "expected behavior" to have the ranges merged based on the We want to keep it user friendly. The "expected behavior" (now default) forces you to parse lsmem output to filter out unnecessary columns (if you care about RANGE only). And in all our utils the --output option really control the output, but no another behavior. Karel -- Karel Zak http://karelzak.blogspot.com -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org