From: Michal Hocko <mhocko@suse.com>
To: Balbir Singh <bsingharora@gmail.com>
Cc: "Jérôme Glisse" <jglisse@redhat.com>, linux-mm <linux-mm@kvack.org>
Subject: Re: [rfc 1/2] mm/hmm: Allow smaps to see zone device public pages
Date: Mon, 23 Oct 2017 10:52:13 +0200 [thread overview]
Message-ID: <20171023085213.xryytzlt7yvjctc2@dhcp22.suse.cz> (raw)
In-Reply-To: <CAKTCnzn4oh1807rwm3yF4THgn79ps35_OKcOTmKA8wfw=KULaw@mail.gmail.com>
On Sat 21-10-17 08:52:27, Balbir Singh wrote:
> On Sat, Oct 21, 2017 at 12:11 AM, Michal Hocko <mhocko@suse.com> wrote:
> > On Wed 18-10-17 17:31:22, Balbir Singh wrote:
> >> vm_normal_page() normally does not return zone device public
> >> pages. In the absence of the visibility the output from smaps
> >> is limited and confusing. It's hard to figure out where the
> >> pages are. This patch uses _vm_normal_page() to expose them
> >> for accounting
> >
> > Maybe I am missing something but does this patch make any sense without
> > patch 2? If no why they are not folded into a single one?
>
>
> I can fold them into one patch. The first patch when applied will just provide
> visibility and they'll show as regular resident pages. The second patch
> then accounts only for them being device memory.
Hmm, I am not really sure. It makes some sense to account mapped HMM
pages as RSS but then I am wondering how HMM differs from other special
mappings (like VM_PFNMAP or VM_MIXEDMAP)?
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2017-10-23 8:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-18 6:31 Balbir Singh
2017-10-18 6:31 ` [rfc 2/2] smaps: Show zone device memory used Balbir Singh
2017-10-18 7:10 ` Anshuman Khandual
2017-10-18 19:48 ` Balbir Singh
2017-10-19 17:02 ` Jerome Glisse
2017-10-21 1:23 ` Balbir Singh
2017-10-20 13:08 ` Michal Hocko
2017-10-20 21:55 ` Balbir Singh
2017-10-23 8:49 ` Michal Hocko
2017-10-23 9:32 ` Balbir Singh
2017-10-23 9:36 ` Michal Hocko
2017-10-23 9:37 ` Balbir Singh
2017-10-18 6:56 ` [rfc 1/2] mm/hmm: Allow smaps to see zone device public pages Anshuman Khandual
2017-10-18 19:36 ` Balbir Singh
2017-10-20 13:11 ` Michal Hocko
2017-10-20 21:52 ` Balbir Singh
2017-10-23 8:52 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171023085213.xryytzlt7yvjctc2@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=bsingharora@gmail.com \
--cc=jglisse@redhat.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox