From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f70.google.com (mail-wm0-f70.google.com [74.125.82.70]) by kanga.kvack.org (Postfix) with ESMTP id A20CA6B0038 for ; Fri, 20 Oct 2017 03:57:36 -0400 (EDT) Received: by mail-wm0-f70.google.com with SMTP id k4so4522330wmc.20 for ; Fri, 20 Oct 2017 00:57:36 -0700 (PDT) Received: from newverein.lst.de (verein.lst.de. [213.95.11.211]) by mx.google.com with ESMTPS id 42si364173wrl.550.2017.10.20.00.57.35 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Oct 2017 00:57:35 -0700 (PDT) Date: Fri, 20 Oct 2017 09:57:35 +0200 From: Christoph Hellwig Subject: Re: [PATCH v3 02/13] dax: require 'struct page' for filesystem dax Message-ID: <20171020075735.GA14378@lst.de> References: <150846713528.24336.4459262264611579791.stgit@dwillia2-desk3.amr.corp.intel.com> <150846714747.24336.14704246566580871364.stgit@dwillia2-desk3.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <150846714747.24336.14704246566580871364.stgit@dwillia2-desk3.amr.corp.intel.com> Sender: owner-linux-mm@kvack.org List-ID: To: Dan Williams Cc: akpm@linux-foundation.org, Jan Kara , linux-nvdimm@lists.01.org, Benjamin Herrenschmidt , Heiko Carstens , linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, Jeff Moyer , Paul Mackerras , Michael Ellerman , Martin Schwidefsky , linux-fsdevel@vger.kernel.org, Ross Zwisler , hch@lst.de, Gerald Schaefer > --- a/arch/powerpc/sysdev/axonram.c > +++ b/arch/powerpc/sysdev/axonram.c > @@ -172,6 +172,7 @@ static size_t axon_ram_copy_from_iter(struct dax_device *dax_dev, pgoff_t pgoff, > > static const struct dax_operations axon_ram_dax_ops = { > .direct_access = axon_ram_dax_direct_access, > + > .copy_from_iter = axon_ram_copy_from_iter, Unrelated whitespace change. That being said - I don't think axonram has devmap support in any form, so this basically becomes dead code, doesn't it? > diff --git a/drivers/s390/block/dcssblk.c b/drivers/s390/block/dcssblk.c > index 7abb240847c0..e7e5db07e339 100644 > --- a/drivers/s390/block/dcssblk.c > +++ b/drivers/s390/block/dcssblk.c > @@ -52,6 +52,7 @@ static size_t dcssblk_dax_copy_from_iter(struct dax_device *dax_dev, > > static const struct dax_operations dcssblk_dax_ops = { > .direct_access = dcssblk_dax_direct_access, > + > .copy_from_iter = dcssblk_dax_copy_from_iter, Same comments apply here. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org