From: Ingo Molnar <mingo@kernel.org>
To: Byungchul Park <byungchul.park@lge.com>
Cc: peterz@infradead.org, tglx@linutronix.de,
linux-kernel@vger.kernel.org, linux-mm@kvack.org, tj@kernel.org,
johannes.berg@intel.com, oleg@redhat.com, amir73il@gmail.com,
david@fromorbit.com, darrick.wong@oracle.com,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-block@vger.kernel.org, hch@infradead.org,
idryomov@gmail.com, kernel-team@lge.com
Subject: Re: [RESEND PATCH 3/3] lockdep: Assign a lock_class per gendisk used for wait_for_completion()
Date: Wed, 18 Oct 2017 11:59:16 +0200 [thread overview]
Message-ID: <20171018095916.gr3n4mal6dz5xs7v@gmail.com> (raw)
In-Reply-To: <1508319532-24655-4-git-send-email-byungchul.park@lge.com>
* Byungchul Park <byungchul.park@lge.com> wrote:
> diff --git a/block/bio.c b/block/bio.c
> index 9a63597..0d4d6c0 100644
> --- a/block/bio.c
> +++ b/block/bio.c
> @@ -941,7 +941,7 @@ int submit_bio_wait(struct bio *bio)
> {
> struct submit_bio_ret ret;
>
> - init_completion(&ret.event);
> + init_completion_with_map(&ret.event, &bio->bi_disk->lockdep_map);
> bio->bi_private = &ret;
> bio->bi_end_io = submit_bio_wait_endio;
> bio->bi_opf |= REQ_SYNC;
> @@ -1382,7 +1382,7 @@ struct bio *bio_map_user_iov(struct request_queue *q,
>
> if (len <= 0)
> break;
> -
> +
> if (bytes > len)
> bytes = len;
>
That's a spurious cleanup unrelated to this patch.
> --- a/include/linux/genhd.h
> +++ b/include/linux/genhd.h
> @@ -3,7 +3,7 @@
>
> /*
> * genhd.h Copyright (C) 1992 Drew Eckhardt
> - * Generic hard disk header file by
> + * Generic hard disk header file by
> * Drew Eckhardt
> *
> * <drew@colorado.edu>
Ditto.
> @@ -483,7 +486,7 @@ struct bsd_disklabel {
> __s16 d_type; /* drive type */
> __s16 d_subtype; /* controller/d_type specific */
> char d_typename[16]; /* type name, e.g. "eagle" */
> - char d_packname[16]; /* pack identifier */
> + char d_packname[16]; /* pack identifier */
> __u32 d_secsize; /* # of bytes per sector */
> __u32 d_nsectors; /* # of data sectors per track */
> __u32 d_ntracks; /* # of tracks per cylinder */
Ditto.
Thanks,
Ingo
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-10-18 9:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-18 9:38 Fix false positive by LOCKDEP_CROSSRELEASE Byungchul Park
2017-10-18 9:38 ` [RESEND PATCH 1/3] completion: Add support for initializing completion with lockdep_map Byungchul Park
2017-10-19 23:24 ` Bart Van Assche
2017-10-20 6:14 ` Byungchul Park
2017-10-20 6:34 ` Thomas Gleixner
2017-10-20 19:58 ` Bart Van Assche
2017-10-21 2:23 ` Byungchul Park
2017-10-22 14:34 ` Bart Van Assche
2017-10-23 2:08 ` Byungchul Park
2017-10-25 7:07 ` Bart Van Assche
2017-10-25 11:49 ` Byungchul Park
2017-10-18 9:38 ` [RESEND PATCH 2/3] lockdep: Remove unnecessary acquisitions wrt workqueue flush Byungchul Park
2017-10-18 9:38 ` [RESEND PATCH 3/3] lockdep: Assign a lock_class per gendisk used for wait_for_completion() Byungchul Park
2017-10-18 9:59 ` Ingo Molnar [this message]
2017-10-19 1:57 ` Byungchul Park
2017-10-18 14:29 ` Fix false positive by LOCKDEP_CROSSRELEASE Bart Van Assche
2017-10-19 1:57 ` Byungchul Park
2017-10-19 14:52 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171018095916.gr3n4mal6dz5xs7v@gmail.com \
--to=mingo@kernel.org \
--cc=amir73il@gmail.com \
--cc=byungchul.park@lge.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=idryomov@gmail.com \
--cc=johannes.berg@intel.com \
--cc=kernel-team@lge.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox