From: Mel Gorman <mgorman@techsingularity.net>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>
Subject: Re: [PATCH] mm, page_alloc: simplify hot/cold page handling in rmqueue_bulk()
Date: Wed, 18 Oct 2017 09:06:31 +0100 [thread overview]
Message-ID: <20171018080631.7ebimdlwek4inits@techsingularity.net> (raw)
In-Reply-To: <20171018073528.30982-1-vbabka@suse.cz>
On Wed, Oct 18, 2017 at 09:35:28AM +0200, Vlastimil Babka wrote:
> The rmqueue_bulk() function fills an empty pcplist with pages from the free
> list. It tries to preserve increasing order by pfn to the caller, because it
> leads to better performance with some I/O controllers, as explained in
> e084b2d95e48 ("page-allocator: preserve PFN ordering when __GFP_COLD is set").
> For callers requesting cold pages, which are obtained from the tail of
> pcplists, it means the pcplist has to be filled in reverse order from the free
> lists (the hot/cold property only applies when pages are recycled on the
> pcplists, not when refilled from free lists).
>
> The related comment in rmqueue_bulk() wasn't clear to me without reading the
> log of the commit mentioned above, so try to clarify it.
>
> The code for filling the pcplists in order determined by the cold flag also
> seems unnecessarily hard to follow. It's sufficient to either use list_add()
> or list_add_tail(), but the current code also updates the list head pointer
> in each step to the last added page, which then counterintuitively requires
> to switch the usage of list_add() and list_add_tail() to achieve the desired
> order, with no apparent benefit. This patch simplifies the code.
>
> Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
The "cold" treatment is dubious because almost everything that frees
considers the page "hot" which limits the usefulness of hot/cold in the
allocator. While I do not see a problem with your patch as such, please
take a look at "mm: Remove __GFP_COLD" in particular. The last 4 patches
in that series make a number of observations on how "cold" is treated in
the allocator.
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-10-18 8:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-18 7:35 Vlastimil Babka
2017-10-18 8:06 ` Mel Gorman [this message]
2017-10-18 8:38 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171018080631.7ebimdlwek4inits@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox