* [mmotm:master 112/209] mm/debug.c:137:21: warning: passing argument 1 of 'mm_pgtables_bytes' discards 'const' qualifier from pointer target type
@ 2017-10-14 7:38 kbuild test robot
2017-10-16 15:01 ` Kirill A. Shutemov
0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2017-10-14 7:38 UTC (permalink / raw)
To: Kirill A. Shutemov
Cc: kbuild-all, Johannes Weiner, Andrew Morton, Linux Memory Management List
[-- Attachment #1: Type: text/plain, Size: 6801 bytes --]
tree: git://git.cmpxchg.org/linux-mmotm.git master
head: cc4a10c92b384ba2b80393c37639808df0ebbf56
commit: ae7f37f07ee1eb08dd1eaaf79182ce9aa6ef7c09 [112/209] mm: consolidate page table accounting
config: blackfin-allmodconfig (attached as .config)
compiler: bfin-uclinux-gcc (GCC) 6.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout ae7f37f07ee1eb08dd1eaaf79182ce9aa6ef7c09
# save the attached .config to linux build tree
make.cross ARCH=blackfin
All warnings (new ones prefixed by >>):
In file included from include/linux/kernel.h:13:0,
from mm/debug.c:8:
mm/debug.c: In function 'dump_mm':
>> mm/debug.c:137:21: warning: passing argument 1 of 'mm_pgtables_bytes' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
mm_pgtables_bytes(mm),
^
include/linux/printk.h:295:35: note: in definition of macro 'pr_emerg'
printk(KERN_EMERG pr_fmt(fmt), ##__VA_ARGS__)
^~~~~~~~~~~
In file included from mm/debug.c:9:0:
include/linux/mm.h:1671:29: note: expected 'struct mm_struct *' but argument is of type 'const struct mm_struct *'
static inline unsigned long mm_pgtables_bytes(struct mm_struct *mm)
^~~~~~~~~~~~~~~~~
vim +137 mm/debug.c
> 8 #include <linux/kernel.h>
9 #include <linux/mm.h>
10 #include <linux/trace_events.h>
11 #include <linux/memcontrol.h>
12 #include <trace/events/mmflags.h>
13 #include <linux/migrate.h>
14 #include <linux/page_owner.h>
15
16 #include "internal.h"
17
18 char *migrate_reason_names[MR_TYPES] = {
19 "compaction",
20 "memory_failure",
21 "memory_hotplug",
22 "syscall_or_cpuset",
23 "mempolicy_mbind",
24 "numa_misplaced",
25 "cma",
26 };
27
28 const struct trace_print_flags pageflag_names[] = {
29 __def_pageflag_names,
30 {0, NULL}
31 };
32
33 const struct trace_print_flags gfpflag_names[] = {
34 __def_gfpflag_names,
35 {0, NULL}
36 };
37
38 const struct trace_print_flags vmaflag_names[] = {
39 __def_vmaflag_names,
40 {0, NULL}
41 };
42
43 void __dump_page(struct page *page, const char *reason)
44 {
45 /*
46 * Avoid VM_BUG_ON() in page_mapcount().
47 * page->_mapcount space in struct page is used by sl[aou]b pages to
48 * encode own info.
49 */
50 int mapcount = PageSlab(page) ? 0 : page_mapcount(page);
51
52 pr_emerg("page:%p count:%d mapcount:%d mapping:%p index:%#lx",
53 page, page_ref_count(page), mapcount,
54 page->mapping, page_to_pgoff(page));
55 if (PageCompound(page))
56 pr_cont(" compound_mapcount: %d", compound_mapcount(page));
57 pr_cont("\n");
58 BUILD_BUG_ON(ARRAY_SIZE(pageflag_names) != __NR_PAGEFLAGS + 1);
59
60 pr_emerg("flags: %#lx(%pGp)\n", page->flags, &page->flags);
61
62 print_hex_dump(KERN_ALERT, "raw: ", DUMP_PREFIX_NONE, 32,
63 sizeof(unsigned long), page,
64 sizeof(struct page), false);
65
66 if (reason)
67 pr_alert("page dumped because: %s\n", reason);
68
69 #ifdef CONFIG_MEMCG
70 if (page->mem_cgroup)
71 pr_alert("page->mem_cgroup:%p\n", page->mem_cgroup);
72 #endif
73 }
74
75 void dump_page(struct page *page, const char *reason)
76 {
77 __dump_page(page, reason);
78 dump_page_owner(page);
79 }
80 EXPORT_SYMBOL(dump_page);
81
82 #ifdef CONFIG_DEBUG_VM
83
84 void dump_vma(const struct vm_area_struct *vma)
85 {
86 pr_emerg("vma %p start %p end %p\n"
87 "next %p prev %p mm %p\n"
88 "prot %lx anon_vma %p vm_ops %p\n"
89 "pgoff %lx file %p private_data %p\n"
90 "flags: %#lx(%pGv)\n",
91 vma, (void *)vma->vm_start, (void *)vma->vm_end, vma->vm_next,
92 vma->vm_prev, vma->vm_mm,
93 (unsigned long)pgprot_val(vma->vm_page_prot),
94 vma->anon_vma, vma->vm_ops, vma->vm_pgoff,
95 vma->vm_file, vma->vm_private_data,
96 vma->vm_flags, &vma->vm_flags);
97 }
98 EXPORT_SYMBOL(dump_vma);
99
100 void dump_mm(const struct mm_struct *mm)
101 {
102 pr_emerg("mm %p mmap %p seqnum %d task_size %lu\n"
103 #ifdef CONFIG_MMU
104 "get_unmapped_area %p\n"
105 #endif
106 "mmap_base %lu mmap_legacy_base %lu highest_vm_end %lu\n"
107 "pgd %p mm_users %d mm_count %d pgtables_bytes %lu map_count %d\n"
108 "hiwater_rss %lx hiwater_vm %lx total_vm %lx locked_vm %lx\n"
109 "pinned_vm %lx data_vm %lx exec_vm %lx stack_vm %lx\n"
110 "start_code %lx end_code %lx start_data %lx end_data %lx\n"
111 "start_brk %lx brk %lx start_stack %lx\n"
112 "arg_start %lx arg_end %lx env_start %lx env_end %lx\n"
113 "binfmt %p flags %lx core_state %p\n"
114 #ifdef CONFIG_AIO
115 "ioctx_table %p\n"
116 #endif
117 #ifdef CONFIG_MEMCG
118 "owner %p "
119 #endif
120 "exe_file %p\n"
121 #ifdef CONFIG_MMU_NOTIFIER
122 "mmu_notifier_mm %p\n"
123 #endif
124 #ifdef CONFIG_NUMA_BALANCING
125 "numa_next_scan %lu numa_scan_offset %lu numa_scan_seq %d\n"
126 #endif
127 "tlb_flush_pending %d\n"
128 "def_flags: %#lx(%pGv)\n",
129
130 mm, mm->mmap, mm->vmacache_seqnum, mm->task_size,
131 #ifdef CONFIG_MMU
132 mm->get_unmapped_area,
133 #endif
134 mm->mmap_base, mm->mmap_legacy_base, mm->highest_vm_end,
135 mm->pgd, atomic_read(&mm->mm_users),
136 atomic_read(&mm->mm_count),
> 137 mm_pgtables_bytes(mm),
138 mm->map_count,
139 mm->hiwater_rss, mm->hiwater_vm, mm->total_vm, mm->locked_vm,
140 mm->pinned_vm, mm->data_vm, mm->exec_vm, mm->stack_vm,
141 mm->start_code, mm->end_code, mm->start_data, mm->end_data,
142 mm->start_brk, mm->brk, mm->start_stack,
143 mm->arg_start, mm->arg_end, mm->env_start, mm->env_end,
144 mm->binfmt, mm->flags, mm->core_state,
145 #ifdef CONFIG_AIO
146 mm->ioctx_table,
147 #endif
148 #ifdef CONFIG_MEMCG
149 mm->owner,
150 #endif
151 mm->exe_file,
152 #ifdef CONFIG_MMU_NOTIFIER
153 mm->mmu_notifier_mm,
154 #endif
155 #ifdef CONFIG_NUMA_BALANCING
156 mm->numa_next_scan, mm->numa_scan_offset, mm->numa_scan_seq,
157 #endif
158 atomic_read(&mm->tlb_flush_pending),
159 mm->def_flags, &mm->def_flags
160 );
161 }
162
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 45903 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [mmotm:master 112/209] mm/debug.c:137:21: warning: passing argument 1 of 'mm_pgtables_bytes' discards 'const' qualifier from pointer target type
2017-10-14 7:38 [mmotm:master 112/209] mm/debug.c:137:21: warning: passing argument 1 of 'mm_pgtables_bytes' discards 'const' qualifier from pointer target type kbuild test robot
@ 2017-10-16 15:01 ` Kirill A. Shutemov
0 siblings, 0 replies; 2+ messages in thread
From: Kirill A. Shutemov @ 2017-10-16 15:01 UTC (permalink / raw)
To: Andrew Morton
Cc: kbuild test robot, kbuild-all, Johannes Weiner,
Linux Memory Management List
On Sat, Oct 14, 2017 at 07:38:55AM +0000, kbuild test robot wrote:
> tree: git://git.cmpxchg.org/linux-mmotm.git master
> head: cc4a10c92b384ba2b80393c37639808df0ebbf56
> commit: ae7f37f07ee1eb08dd1eaaf79182ce9aa6ef7c09 [112/209] mm: consolidate page table accounting
> config: blackfin-allmodconfig (attached as .config)
> compiler: bfin-uclinux-gcc (GCC) 6.2.0
> reproduce:
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> git checkout ae7f37f07ee1eb08dd1eaaf79182ce9aa6ef7c09
> # save the attached .config to linux build tree
> make.cross ARCH=blackfin
>
> All warnings (new ones prefixed by >>):
>
> In file included from include/linux/kernel.h:13:0,
> from mm/debug.c:8:
> mm/debug.c: In function 'dump_mm':
> >> mm/debug.c:137:21: warning: passing argument 1 of 'mm_pgtables_bytes' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
> mm_pgtables_bytes(mm),
> ^
> include/linux/printk.h:295:35: note: in definition of macro 'pr_emerg'
> printk(KERN_EMERG pr_fmt(fmt), ##__VA_ARGS__)
> ^~~~~~~~~~~
> In file included from mm/debug.c:9:0:
> include/linux/mm.h:1671:29: note: expected 'struct mm_struct *' but argument is of type 'const struct mm_struct *'
> static inline unsigned long mm_pgtables_bytes(struct mm_struct *mm)
Andrew, could you please take this fixup:
diff --git a/include/linux/mm.h b/include/linux/mm.h
index a7e50c464021..d3c4b1f19da4 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -1668,7 +1668,7 @@ static inline void mm_dec_nr_ptes(struct mm_struct *mm)
#else
static inline void mm_pgtables_bytes_init(struct mm_struct *mm) {}
-static inline unsigned long mm_pgtables_bytes(struct mm_struct *mm)
+static inline unsigned long mm_pgtables_bytes(const struct mm_struct *mm)
{
return 0;
}
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-16 15:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-14 7:38 [mmotm:master 112/209] mm/debug.c:137:21: warning: passing argument 1 of 'mm_pgtables_bytes' discards 'const' qualifier from pointer target type kbuild test robot
2017-10-16 15:01 ` Kirill A. Shutemov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox