From: Andi Kleen <ak@linux.intel.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Luis Felipe Sandoval Castro
<luis.felipe.sandoval.castro@intel.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, vbabka@suse.cz, mingo@kernel.org,
rientjes@google.com, n-horiguchi@ah.jp.nec.com,
salls@cs.ucsb.edu, Cristopher Lameter <cl@linux.com>
Subject: Re: [PATCH v1] mm/mempolicy.c: Fix get_nodes() off-by-one error.
Date: Thu, 12 Oct 2017 08:28:25 -0700 [thread overview]
Message-ID: <20171012152825.GJ5109@tassilo.jf.intel.com> (raw)
In-Reply-To: <20171012084633.ipr5cfxsrs3lyb5n@dhcp22.suse.cz>
On Thu, Oct 12, 2017 at 10:46:33AM +0200, Michal Hocko wrote:
> [CC Christoph who seems to be the author of the code]
Actually you can blame me. I did the mistake originally.
It was found many years ago, but then it was already too late
to change.
> Andi has voiced a concern about backward compatibility but I am not sure
> the risk is very high. The current behavior is simply broken unless you
> use a large maxnode anyway. What kind of breakage would you envision
> Andi?
libnuma uses the available number of nodes as max.
So it would always lose the last one with your chance.
Your change would be catastrophic.
The only way to fix it really would be to define
a new syscall. But I don't think it is needed,
the existing maxnode+1 interface works
(just should be properly documented)
-Andi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-10-12 15:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-06 13:36 [PATCH v1][cover-letter] " Luis Felipe Sandoval Castro
2017-10-06 13:36 ` [PATCH v1] " Luis Felipe Sandoval Castro
2017-10-12 8:46 ` Michal Hocko
2017-10-12 9:14 ` Vlastimil Babka
2017-10-12 9:29 ` Michal Hocko
2017-10-12 15:28 ` Andi Kleen [this message]
2017-10-13 8:04 ` Michal Hocko
2017-10-19 3:48 ` Sandoval Castro, Luis Felipe
2017-10-19 4:28 ` Andi Kleen
2017-10-06 22:12 ` [PATCH v1][cover-letter] " Andi Kleen
-- strict thread matches above, loose matches on Subject: below --
2017-07-18 13:39 [PATCH v1] " Luis Felipe Sandoval Castro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171012152825.GJ5109@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luis.felipe.sandoval.castro@intel.com \
--cc=mhocko@kernel.org \
--cc=mingo@kernel.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=rientjes@google.com \
--cc=salls@cs.ucsb.edu \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox