From: Catalin Marinas <catalin.marinas@arm.com>
To: shuwang@redhat.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
chuhu@redhat.com, yizhan@redhat.com
Subject: Re: [PATCH] mm: kmemleak: start address align for scan_large_block
Date: Wed, 11 Oct 2017 10:42:49 +0100 [thread overview]
Message-ID: <20171011094249.sot6wmafgrk374tg@localhost> (raw)
In-Reply-To: <20171011085334.7391-1-shuwang@redhat.com>
On Wed, Oct 11, 2017 at 04:53:34PM +0800, shuwang@redhat.com wrote:
> From: Shu Wang <shuwang@redhat.com>
>
> If the start address is not ptr bytes aligned, it may cause false
> positives when a pointer is split by MAX_SCAN_SIZE.
>
> For example:
> tcp_metrics_nl_family is in __ro_after_init area. On my PC, the
> __start_ro_after_init is not ptr aligned, and
> tcp_metrics_nl_family->attrbuf was break by MAX_SCAN_SIZE.
>
> # cat /proc/kallsyms | grep __start_ro_after_init
> ffffffff81afac8b R __start_ro_after_init
>
> (gdb) p &tcp_metrics_nl_family->attrbuf
> (struct nlattr ***) 0xffffffff81b12c88 <tcp_metrics_nl_family+72>
>
> (gdb) p tcp_metrics_nl_family->attrbuf
> (struct nlattr **) 0xffff88007b9d9400
>
> scan_block(_start=0xffffffff81b11c8b, _end=0xffffffff81b12c8b, 0)
> scan_block(_start=0xffffffff81b12c8b, _end=0xffffffff81b13c8b, 0)
>
> unreferenced object 0xffff88007b9d9400 (size 128):
> backtrace:
> kmemleak_alloc+0x4a/0xa0
> __kmalloc+0xec/0x220
> genl_register_family.part.8+0x11c/0x5c0
> genl_register_family+0x6f/0x90
> tcp_metrics_init+0x33/0x47
> tcp_init+0x27a/0x293
> inet_init+0x176/0x28a
> do_one_initcall+0x51/0x1b0
>
> Signed-off-by: Shu Wang <shuwang@redhat.com>
Nice catch. Thanks.
Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2017-10-11 9:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-11 8:53 shuwang
2017-10-11 9:42 ` Catalin Marinas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171011094249.sot6wmafgrk374tg@localhost \
--to=catalin.marinas@arm.com \
--cc=chuhu@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shuwang@redhat.com \
--cc=yizhan@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox