From: Roman Gushchin <guro@fb.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Shakeel Butt <shakeelb@google.com>, Linux MM <linux-mm@kvack.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Tejun Heo <tj@kernel.org>,
kernel-team@fb.com, Cgroups <cgroups@vger.kernel.org>,
linux-doc@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [v10 3/6] mm, oom: cgroup-aware OOM killer
Date: Thu, 5 Oct 2017 12:45:51 +0100 [thread overview]
Message-ID: <20171005114551.GA6338@castle.dhcp.TheFacebook.com> (raw)
In-Reply-To: <20171005111230.i7am3patptvalcat@dhcp22.suse.cz>
On Thu, Oct 05, 2017 at 01:12:30PM +0200, Michal Hocko wrote:
> On Thu 05-10-17 11:27:07, Roman Gushchin wrote:
> > On Wed, Oct 04, 2017 at 02:24:26PM -0700, Shakeel Butt wrote:
> [...]
> > > Sorry about the confusion. There are two things. First, should we do a
> > > css_get on the newly selected memcg within the for loop when we still
> > > have a reference to it?
> >
> > We're holding rcu_read_lock, it should be enough. We're bumping css counter
> > just before releasing rcu lock.
>
> yes
>
> > >
> > > Second, for the OFFLINE memcg, you are right oom_evaluate_memcg() will
> > > return 0 for offlined memcgs. Maybe no need to call
> > > oom_evaluate_memcg() for offlined memcgs.
> >
> > Sounds like a good optimization, which can be done on top of the current
> > patchset.
>
> You could achive this by checking whether a memcg has tasks rather than
> explicitly checking for children memcgs as I've suggested already.
Using cgroup_has_tasks() will require additional locking, so I'm not sure
it worth it.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-10-05 11:46 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 15:46 [v10 0/6] " Roman Gushchin
2017-10-04 15:46 ` [v10 1/6] mm, oom: refactor the oom_kill_process() function Roman Gushchin
2017-10-04 19:14 ` Johannes Weiner
2017-10-04 15:46 ` [v10 2/6] mm: implement mem_cgroup_scan_tasks() for the root memory cgroup Roman Gushchin
2017-10-04 19:15 ` Johannes Weiner
2017-10-04 20:10 ` David Rientjes
2017-10-04 15:46 ` [v10 3/6] mm, oom: cgroup-aware OOM killer Roman Gushchin
2017-10-04 19:27 ` Johannes Weiner
2017-10-04 19:51 ` Roman Gushchin
2017-10-04 20:17 ` David Rientjes
2017-10-04 20:22 ` Roman Gushchin
2017-10-04 20:31 ` Johannes Weiner
2017-10-05 11:14 ` Michal Hocko
2017-10-04 19:48 ` Shakeel Butt
2017-10-04 20:15 ` Roman Gushchin
2017-10-04 21:24 ` Shakeel Butt
2017-10-05 10:27 ` Roman Gushchin
2017-10-05 11:12 ` Michal Hocko
2017-10-05 11:45 ` Roman Gushchin [this message]
2017-10-04 20:27 ` David Rientjes
2017-10-04 20:41 ` Johannes Weiner
2017-10-05 8:40 ` David Rientjes
2017-10-05 10:27 ` Johannes Weiner
2017-10-05 21:53 ` David Rientjes
2017-10-05 10:44 ` Roman Gushchin
2017-10-05 22:02 ` David Rientjes
2017-10-06 5:43 ` Michal Hocko
2017-10-05 11:40 ` Michal Hocko
2017-10-04 15:46 ` [v10 4/6] mm, oom: introduce memory.oom_group Roman Gushchin
2017-10-04 19:37 ` Johannes Weiner
2017-10-05 12:06 ` Michal Hocko
2017-10-05 12:32 ` Roman Gushchin
2017-10-05 12:58 ` Michal Hocko
2017-10-04 15:46 ` [v10 5/6] mm, oom: add cgroup v2 mount option for cgroup-aware OOM killer Roman Gushchin
2017-10-04 20:04 ` Johannes Weiner
2017-10-05 13:14 ` Michal Hocko
2017-10-05 13:41 ` Roman Gushchin
2017-10-05 14:10 ` Michal Hocko
2017-10-05 14:54 ` Johannes Weiner
2017-10-05 16:40 ` Michal Hocko
2017-10-05 15:51 ` Tejun Heo
2017-10-04 15:46 ` [v10 6/6] mm, oom, docs: describe the " Roman Gushchin
2017-10-04 20:08 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171005114551.GA6338@castle.dhcp.TheFacebook.com \
--to=guro@fb.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=rientjes@google.com \
--cc=shakeelb@google.com \
--cc=tj@kernel.org \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox