From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Mike Kravetz <mike.kravetz@oracle.com>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-api@vger.kernel.org, Michal Hocko <mhocko@kernel.org>
Subject: Re: [PATCH 1/2] mm: Introduce wrapper to access mm->nr_ptes
Date: Thu, 5 Oct 2017 13:10:13 +0300 [thread overview]
Message-ID: <20171005101013.hdf7hjkcl4l7aw2a@node.shutemov.name> (raw)
In-Reply-To: <e90bf773-330c-74d0-a0de-57e1783ebd9e@oracle.com>
On Wed, Oct 04, 2017 at 11:35:47AM -0700, Mike Kravetz wrote:
> On 10/04/2017 09:36 AM, Kirill A. Shutemov wrote:
> > @@ -813,7 +813,7 @@ static struct mm_struct *mm_init(struct mm_struct *mm, struct task_struct *p,
> > init_rwsem(&mm->mmap_sem);
> > INIT_LIST_HEAD(&mm->mmlist);
> > mm->core_state = NULL;
> > - atomic_long_set(&mm->nr_ptes, 0);
> > + mm_nr_ptes_init(mm);
> > mm_nr_pmds_init(mm);
> > mm_nr_puds_init(mm);
> > mm->map_count = 0;
> > @@ -869,9 +869,9 @@ static void check_mm(struct mm_struct *mm)
> > "mm:%p idx:%d val:%ld\n", mm, i, x);
> > }
> >
> > - if (atomic_long_read(&mm->nr_ptes))
> > + if (mm_nr_pmds(mm))
>
> Should that be?
>
> if (mm_nr_ptes(mm))
Thanks, for catching this.
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2017-10-05 10:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 16:36 Kirill A. Shutemov
2017-10-04 16:36 ` [PATCH 2/2] mm: Consolidate page table accounting Kirill A. Shutemov
2017-10-05 5:08 ` Anshuman Khandual
2017-10-05 10:10 ` Kirill A. Shutemov
2017-10-04 18:35 ` [PATCH 1/2] mm: Introduce wrapper to access mm->nr_ptes Mike Kravetz
2017-10-05 10:10 ` Kirill A. Shutemov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171005101013.hdf7hjkcl4l7aw2a@node.shutemov.name \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mike.kravetz@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox