From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f198.google.com (mail-wr0-f198.google.com [209.85.128.198]) by kanga.kvack.org (Postfix) with ESMTP id 2D65C6B0038 for ; Mon, 2 Oct 2017 16:55:57 -0400 (EDT) Received: by mail-wr0-f198.google.com with SMTP id k10so6760261wrk.4 for ; Mon, 02 Oct 2017 13:55:57 -0700 (PDT) Received: from mx1.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id e22si6161131wre.203.2017.10.02.13.55.55 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 02 Oct 2017 13:55:55 -0700 (PDT) Date: Mon, 2 Oct 2017 22:55:52 +0200 From: Michal Hocko Subject: Re: [v8 0/4] cgroup-aware OOM killer Message-ID: <20171002205552.3ygveyd7yrcvkz7u@dhcp22.suse.cz> References: <20170927162300.GA5623@castle.DHCP.thefacebook.com> <20171002122434.llbaarb6yw3o3mx3@dhcp22.suse.cz> <20171002192814.sad75tqklp3nmr4m@dhcp22.suse.cz> <20171002195601.3jeocmmzyf2jl3dw@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Shakeel Butt Cc: Tim Hockin , Roman Gushchin , Johannes Weiner , Tejun Heo , kernel-team@fb.com, David Rientjes , Linux MM , Vladimir Davydov , Tetsuo Handa , Andrew Morton , Cgroups , linux-doc@vger.kernel.org, "linux-kernel@vger.kernel.org" On Mon 02-10-17 13:24:25, Shakeel Butt wrote: > On Mon, Oct 2, 2017 at 12:56 PM, Michal Hocko wrote: > > On Mon 02-10-17 12:45:18, Shakeel Butt wrote: > >> > I am sorry to cut the rest of your proposal because it simply goes over > >> > the scope of the proposed solution while the usecase you are mentioning > >> > is still possible. If we want to compare intermediate nodes (which seems > >> > to be the case) then we can always provide a knob to opt-in - be it your > >> > oom_gang or others. > >> > >> In the Roman's proposed solution we can already force the comparison > >> of intermediate nodes using 'oom_group', I am just requesting to > >> separate the killall semantics from it. > > > > oom_group _is_ about killall semantic. And comparing killable entities > > is just a natural thing to do. So I am not sure what you mean > > > > I am saying decouple the notion of comparable entities and killable entities. There is no strong (bijection) relation there. Right now killable entities are comparable (which I hope we agree is the right thing to do) but nothing really prevents even non-killable entities to be compared in the future. -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org