From: Alexandru Moise <00moses.alexander00@gmail.com>
To: akpm@linux-foundation.org
Cc: mike.kravetz@oracle.com, mhocko@suse.com,
n-horiguchi@ah.jp.nec.com, aneesh.kumar@linux.vnet.ibm.com,
punit.agrawal@arm.com, gerald.schaefer@de.ibm.com,
aarcange@redhat.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, kirill@shutemov.name
Subject: [PATCH] mm, hugetlb: fix "treat_as_movable" condition in htlb_alloc_mask
Date: Fri, 29 Sep 2017 17:13:39 +0200 [thread overview]
Message-ID: <20170929151339.GA4398@gmail.com> (raw)
If hugepage_migration_supported() returns true, this renders the
hugepages_treat_as_movable sysctl completely pointless.
Let's keep this behavior optional by switching the if() condition
from || to &&.
Signed-off-by: Alexandru Moise <00moses.alexander00@gmail.com>
---
mm/hugetlb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 424b0ef08a60..ab28de0122af 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -926,7 +926,7 @@ static struct page *dequeue_huge_page_nodemask(struct hstate *h, gfp_t gfp_mask,
/* Movability of hugepages depends on migration support. */
static inline gfp_t htlb_alloc_mask(struct hstate *h)
{
- if (hugepages_treat_as_movable || hugepage_migration_supported(h))
+ if (hugepages_treat_as_movable && hugepage_migration_supported(h))
return GFP_HIGHUSER_MOVABLE;
else
return GFP_HIGHUSER;
--
2.14.2
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2017-09-29 15:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-29 15:13 Alexandru Moise [this message]
2017-09-29 20:43 ` Alexandru Moise
2017-09-29 21:16 ` Mike Kravetz
2017-09-30 8:35 ` Alexandru Moise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170929151339.GA4398@gmail.com \
--to=00moses.alexander00@gmail.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=gerald.schaefer@de.ibm.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mike.kravetz@oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=punit.agrawal@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox